Reduce size of Expr struct
#14366
Draft
Reduce size of Expr struct
#14366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
reviewed
Jan 29, 2025
findepi
reviewed
Jan 29, 2025
Comment on lines
2437
to
2439
| return Some(idx + input_len); | ||
| } else { | ||
| None |
alamb
force-pushed
the
alamb/make_expr_smaller
branch
from
b25ba57 to
f5df767
Compare
github-actions
bot
added
sql
alamb
commented
Jan 29, 2025
Co-authored-by: Felipe Oliveira Carvalho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
@waynexia 's comment on #14256 (comment) got me thinking maybe the build time regression had something to do with the size of
ExprSo I poked around for ways to reduce the size, and I found that currently
Expris 272 bytesWhat changes are included in this PR?
ExprExpr::WindowFunction(WindowFunction) -->Expr::WindowFunction(Box<WindowFunction>) -- which drops the size ofExprfrom 272 to112` bytesAre these changes tested?
functionally by CI
TODO:
Are there any user-facing changes?