Consolidate and expand ident normalization tests #14374
Open
+134
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jan 30, 2025
| @@ -637,46 +637,6 @@ select * from table_without_values; | |||
| statement ok | |||
| set datafusion.catalog.information_schema = true; | |||
|
|
|||
| statement ok | |||
There was a problem hiding this comment.
I moved these tests to a new file
alamb
commented
Jan 30, 2025
| @@ -1802,24 +1802,6 @@ SELECT acos(); | |||
| statement error | |||
| SELECT isnan(); | |||
|
|
|||
| # turn off enable_ident_normalization | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
While writing up some notes from a conversation with @lmwnshn I got myself confusesed about how and if
ident_noralizationworked and couldn't find any tests that showed what I wantedThis is a recurring theme so I think it is worth spending time to make it better.
See related conversation here
What changes are included in this PR?
Are these changes tested?
Only tests
Are there any user-facing changes?
Only tests.
I would like to improve the documentation in this area too (specifically make sure the option is documented in datafusion and datafusion-python)