move resolve_table_references out of datafusion-catalog`
#14441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Thank you so much @logan-keede
I also took the liberty of applying a few updates from #14365 to this PR as well ❤️
FYI here is something else that would be fun: #14444
github-actions
bot
added
optimizer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
datafusion_sql::ResolvedTableReference and TableReference#14365.Rationale for this change
as suggested by @alamb in above PRs
What changes are included in this PR?
refactor of resolve_table_references and deprecation notice
Are these changes tested?
yes
Are there any user-facing changes?
deprecation warning