[Feature-16396][storage-plugin] Tencent Cloud COS Storage Plugin #16565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mighten
requested review from
EricGao888,
SbloodyS,
caishunfeng,
Gallardot and
ruanwenjun
as code owners
Mighten
changed the title
Mighten
changed the title
Mighten
changed the title
SbloodyS
requested changes
Sep 2, 2024
ruanwenjun
reviewed
Sep 2, 2024
dolphinscheduler-storage-plugin/dolphinscheduler-storage-cos/src/test/resources/logback.xml
Show resolved
Hide resolved
...eduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/TaskConstants.java
Outdated
Show resolved
Hide resolved
ruanwenjun
reviewed
Sep 2, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...age-cos/src/main/java/org/apache/dolphinscheduler/plugin/storage/cos/CosStorageOperator.java
Fixed
Show fixed
Hide fixed
...age-cos/src/main/java/org/apache/dolphinscheduler/plugin/storage/cos/CosStorageOperator.java
Fixed
Show fixed
Hide fixed
Mighten
force-pushed
the
feature-16396
branch
2 times, most recently
from
ea644bc
to
40e5ff2
Compare
we should remove bcprov-jdk15on-1.69
|
Mighten
force-pushed
the
feature-16396
branch
4 times, most recently
from
8a33b77
to
037a91b
Compare
fuchanghai
reviewed
Sep 21, 2024
| @Override | ||
| public String getStorageBaseDirectory() { | ||
| // All directory should end with File.separator | ||
| if (resourceBaseAbsolutePath.startsWith("/")) { |
There was a problem hiding this comment.
use File.separator to instead of /
There was a problem hiding this comment.
The File.separator works poorly on Windows 11 x64.
- When the user successfully uploads the "test.log" file, there is no way to enter the deeper directory to view the file.
- When the user tries to delete the folder, an exception is thrown stating that the folder does not exist.
So, for now, I think we should continue using the UNIX filesystem separator ("/"), just like the already existing code, until a DSIP for Windows platform compatibility is provided.
fuchanghai
reviewed
Sep 21, 2024
...age-cos/src/main/java/org/apache/dolphinscheduler/plugin/storage/cos/CosStorageOperator.java
Outdated
Show resolved
Hide resolved
...age-cos/src/main/java/org/apache/dolphinscheduler/plugin/storage/cos/CosStorageOperator.java
Show resolved
Hide resolved
.../src/main/java/org/apache/dolphinscheduler/plugin/storage/cos/CosStorageOperatorFactory.java
Outdated
Show resolved
Hide resolved
Mighten
force-pushed
the
feature-16396
branch
from
037a91b
to
a1fdd4c
Compare
fuchanghai
reviewed
Sep 21, 2024
...ge-cos/src/main/java/org/apache/dolphinscheduler/plugin/storage/cos/CosStorageConstants.java
Outdated
Show resolved
Hide resolved
Mighten
force-pushed
the
feature-16396
branch
from
a1fdd4c
to
b4a834e
Compare
fuchanghai
approved these changes
Sep 22, 2024
Mighten
force-pushed
the
feature-16396
branch
2 times, most recently
from
3dfe6fd
to
95764d1
Compare
* Fixed SonarCloud Quality Readability B (required >= A) * Added missing license files * YAML-ized Tencent COS configuration from common.properties * Added remote logger support with Tencent COS
* Removed redundant dependency: `bcprov-jdk15on-1.69.jar` * Relocated Tencent COS Constants, and reduced magic values in COS with constants * Isolated cloud storage configuration in `common.properties` -> `resource-center.yaml` * Fixed CodeQL: Uncontrolled data used in path expression
Mighten
force-pushed
the
feature-16396
branch
from
95764d1
to
cef94a5
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
This pull request adds a Storage Plugin to the DS Resource Center to support Tencent Cloud COS and aims to close #16396 .
Brief change log
dolphinscheduler-storage-cosindolphinscheduler-storage-pluginVerify this pull request
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md