-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix-16578] Fix environment resource permission #16579
[Fix-16578] Fix environment resource permission #16579
Conversation
...main/java/org/apache/dolphinscheduler/api/permission/ResourcePermissionCheckServiceImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...main/java/org/apache/dolphinscheduler/api/permission/ResourcePermissionCheckServiceImpl.java
Outdated
Show resolved
Hide resolved
…mpl.EnvironmentResourcePermissionCheck
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bfe35e0
to
c8ff459
Compare
You should check failed UT. @wangxj3 |
…om:wangxj3/dolphinscheduler into fix-EnvironmentResourcePermission-upstream
ok |
Quality Gate passedIssues Measures |
Purpose of the pull request
fix #16578
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md