Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-16786][Datasource] Fix jdbc connect parameters json validation question #16787

Merged

Conversation

sdhzwc
Copy link
Contributor

@sdhzwc sdhzwc commented Nov 7, 2024

Purpose of the pull request

image
close #16786

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@github-actions github-actions bot added the UI ui and front end related label Nov 7, 2024
@sdhzwc sdhzwc changed the title [FIX-16786 ][DATABASES] Fix jdbc connect parameters json validation question [FIX-16786 ][DATASOURCE] Fix jdbc connect parameters json validation question Nov 7, 2024
@sdhzwc sdhzwc changed the title [FIX-16786 ][DATASOURCE] Fix jdbc connect parameters json validation question [FIX-16786 ][Datasource] Fix jdbc connect parameters json validation question Nov 7, 2024
@sdhzwc sdhzwc changed the title [FIX-16786 ][Datasource] Fix jdbc connect parameters json validation question [Fix-16786][Datasource] Fix jdbc connect parameters json validation question Nov 7, 2024
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@SbloodyS SbloodyS added this to the 3.3.0 milestone Nov 8, 2024
@SbloodyS SbloodyS added the bug Something isn't working label Nov 8, 2024
Copy link

sonarcloud bot commented Nov 8, 2024

@SbloodyS SbloodyS merged commit a68c2a6 into apache:dev Nov 8, 2024
70 checks passed
@sdhzwc sdhzwc deleted the jdbc-connect-parameters-json-validation-question branch November 8, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Datasource] jdbc connect parameters json validation question
3 participants