[enchement](schema change)Standardize the behavior after a table schema change. #47471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 32452 ms |
TPC-DS: Total hot run time: 192144 ms |
ClickBench: Total hot run time: 30.49 s |
|
run buildall |
TPC-H: Total hot run time: 32539 ms |
TPC-DS: Total hot run time: 192302 ms |
ClickBench: Total hot run time: 31.05 s |
|
TeamCity be ut coverage result: |
hubgeter
force-pushed
the
schema_change
branch
3 times, most recently
from
0250377 to
337ca4f
Compare
|
run buildall |
TPC-H: Total hot run time: 31774 ms |
TPC-DS: Total hot run time: 189473 ms |
ClickBench: Total hot run time: 30.29 s |
|
run buildall |
TPC-H: Total hot run time: 31455 ms |
TPC-DS: Total hot run time: 188909 ms |
ClickBench: Total hot run time: 30.04 s |
hubgeter
force-pushed
the
schema_change
branch
from
52a77d0 to
e7b7af0
Compare
|
run buildall |
TPC-H: Total hot run time: 31598 ms |
TPC-DS: Total hot run time: 189625 ms |
ClickBench: Total hot run time: 30.14 s |
|
TeamCity be ut coverage result: |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Feb 28, 2025
…ma change. (apache#47471) ### What problem does this PR solve? Related PR: apache#32873 Problem Summary: Explicitly defines the behavior of column type conversions. <img width="935" alt="image" src="https://github.com/user-attachments/assets/1e5afcf6-fbcf-4c36-b44e-82843feacb05" /> Special notes are as follows: `String => boolean`: In Parquet, only "false", "off", "no", "0", and an empty string ("") are considered false; otherwise, it is true. In Orc, a string can be parsed as a number, and if that number is 0, it is considered false; otherwise, it is true. If parsing the number fails, it results in null. Conversion between `Int/smallint/tinyint/bigint`: Unless the conversion can be perfectly represented, an error will be reported. For example: Bigint column => smallint column Reason: [INTERNAL_ERROR] Failed to cast value '9223372036854775807' to Nullable(Int16) column. Conversion between `Decimal`: Unless the conversion can be perfectly done, an error will be reported. `String => Int/smallint/tinyint/bigint`: It can be successfully converted to a number, and the number can be correctly stored. Otherwise, the result is null. `Int/smallint/tinyint/bigint => float`: The conversion is successful only if abs(number type) < 2^23. `Int/smallint/tinyint/bigint => double`: The conversion is successful only if abs(number type) < 2^52. `Decimal => Int/smallint/tinyint/bigint`: If the integer part of the decimal can be perfectly stored, only the integer part will be shown; otherwise, it will result in null. `Float => double`: Refer to the C++ static_cast<double>(float). `Decimal => float/double`: Attempt to store the approximate value. `Boolean => string`: The conversion will result in “TRUE” or “FALSE”. TODO: conversion to `char/varchar` type requires truncation.
mymeiyi
pushed a commit
to mymeiyi/doris
that referenced
this pull request
Mar 4, 2025
…ma change. (apache#47471) ### What problem does this PR solve? Related PR: apache#32873 Problem Summary: Explicitly defines the behavior of column type conversions. <img width="935" alt="image" src="https://github.com/user-attachments/assets/1e5afcf6-fbcf-4c36-b44e-82843feacb05" /> Special notes are as follows: `String => boolean`: In Parquet, only "false", "off", "no", "0", and an empty string ("") are considered false; otherwise, it is true. In Orc, a string can be parsed as a number, and if that number is 0, it is considered false; otherwise, it is true. If parsing the number fails, it results in null. Conversion between `Int/smallint/tinyint/bigint`: Unless the conversion can be perfectly represented, an error will be reported. For example: Bigint column => smallint column Reason: [INTERNAL_ERROR] Failed to cast value '9223372036854775807' to Nullable(Int16) column. Conversion between `Decimal`: Unless the conversion can be perfectly done, an error will be reported. `String => Int/smallint/tinyint/bigint`: It can be successfully converted to a number, and the number can be correctly stored. Otherwise, the result is null. `Int/smallint/tinyint/bigint => float`: The conversion is successful only if abs(number type) < 2^23. `Int/smallint/tinyint/bigint => double`: The conversion is successful only if abs(number type) < 2^52. `Decimal => Int/smallint/tinyint/bigint`: If the integer part of the decimal can be perfectly stored, only the integer part will be shown; otherwise, it will result in null. `Float => double`: Refer to the C++ static_cast<double>(float). `Decimal => float/double`: Attempt to store the approximate value. `Boolean => string`: The conversion will result in “TRUE” or “FALSE”. TODO: conversion to `char/varchar` type requires truncation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related PR: #32873
Problem Summary:
Explicitly defines the behavior of column type conversions.
Special notes are as follows:
String => boolean: In Parquet, only "false", "off", "no", "0", and an empty string ("") are considered false; otherwise, it is true. In Orc, a string can be parsed as a number, and if that number is 0, it is considered false; otherwise, it is true. If parsing the number fails, it results in null.Conversion between
Int/smallint/tinyint/bigint:Unless the conversion can be perfectly represented, an error will be reported.
For example:
Bigint column => smallint column
Reason: [INTERNAL_ERROR] Failed to cast value '9223372036854775807' to Nullable(Int16) column.
Conversion between
Decimal:Unless the conversion can be perfectly done, an error will be reported.
String => Int/smallint/tinyint/bigint:It can be successfully converted to a number, and the number can be correctly stored. Otherwise, the result is null.
Int/smallint/tinyint/bigint => float:The conversion is successful only if abs(number type) < 2^23.
Int/smallint/tinyint/bigint => double:The conversion is successful only if abs(number type) < 2^52.
Decimal => Int/smallint/tinyint/bigint:If the integer part of the decimal can be perfectly stored, only the integer part will be shown; otherwise, it will result in null.
Float => double:Refer to the C++ static_cast(float).
Decimal => float/double:Attempt to store the approximate value.
Boolean => string:The conversion will result in “TRUE” or “FALSE”.
TODO: conversion to
char/varchartype requires truncation.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)