-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-37426][FLIP-481] Introduce Event Reporting #26316
Conversation
...link-metrics-otel/src/main/java/org/apache/flink/events/otel/OpenTelemetryEventReporter.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice that we are using open telemetry libraries. Can we promote in the docs how we are using open telemetry with this Flip and how it might ease Flink open telemetry adoption.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I forgot to mention that I had to split this effort into more steps. Here for example we are still missing actual usage of events by the Flink itself (as proposed/defined in the FLIP). I would also like to document everything in a separate ticket to not block this PR. I've created separate tickets for both of those things: |
…and implementations.
What is the purpose of the change
https://cwiki.apache.org/confluence/display/FLINK/FLIP-481%3A+Introduce+Event+Reporting
Brief change log
Please check the individual commit mesages.
Verifying this change
Refactoring is covered by the existing tests. For Events reporting this adds bunch of new tests, including an ITCase integrating with Otel container.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation