Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-37426][FLIP-481] Introduce Event Reporting #26316

Merged
merged 12 commits into from
Mar 26, 2025

Conversation

pnowojski
Copy link
Contributor

What is the purpose of the change

https://cwiki.apache.org/confluence/display/FLINK/FLIP-481%3A+Introduce+Event+Reporting

Brief change log

Please check the individual commit mesages.

Verifying this change

Refactoring is covered by the existing tests. For Events reporting this adds bunch of new tests, including an ITCase integrating with Otel container.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 18, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@davidradl davidradl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice that we are using open telemetry libraries. Can we promote in the docs how we are using open telemetry with this Flip and how it might ease Flink open telemetry adoption.

Copy link
Contributor

@StefanRRichter StefanRRichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pnowojski pnowojski changed the title [FLIP-481][FLINK-37426] Introduce Event Reporting [FLINK-37426][FLIP-481] Introduce Event Reporting Mar 26, 2025
@pnowojski
Copy link
Contributor Author

I notice that we are using open telemetry libraries. Can we promote in the docs how we are using open telemetry with this Flip and how it might ease Flink open telemetry adoption.

I forgot to mention that I had to split this effort into more steps. Here for example we are still missing actual usage of events by the Flink itself (as proposed/defined in the FLIP). I would also like to document everything in a separate ticket to not block this PR.

I've created separate tickets for both of those things:
https://issues.apache.org/jira/browse/FLINK-37560
https://issues.apache.org/jira/browse/FLINK-37561

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants