Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-37533][CI] Add action: write permission to stale PR github action #26360

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

tomncooper
Copy link
Contributor

@tomncooper tomncooper commented Mar 27, 2025

What is the purpose of the change

#26336 Reduced the timeouts on the Stale PR GitHub action. However, changing these means that the action need to change the cache it keeps of PRs it has checked and (as per the 403 errors in the Actions log) it does not seem to have these.

Some digging shows that the issue can be fixed by adding the actions: write permission to the workflow.

Brief change log

  • Add actions: write permission to the stale PR GitHub Action workflow.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 27, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@rmetzger rmetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to merge

@rmetzger rmetzger merged commit 56e1e76 into apache:master Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants