-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#4698] feat(auth-ranger): Extended Ranger authorization by rules #4744
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
9fe3aa2
[#4698] feat(core): Extended Apache Ranger authorization by configura…
xunliu fefc415
remove .template suffix
xunliu 9af7222
fix
xunliu dc0b6f0
override default configure
xunliu 87d52af
move config file
xunliu aa99c5c
remove configuration
xunliu acefec2
update docs
xunliu 1542d74
rollback gradlew script change
xunliu 37a5048
rename interface name
xunliu ee217a3
add return type
xunliu 86731ca
singleton
xunliu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75 changes: 75 additions & 0 deletions
75
...rc/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationHivePlugin.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
package org.apache.gravitino.authorization.ranger; | ||
|
||
import com.google.common.collect.ImmutableList; | ||
import com.google.common.collect.ImmutableMap; | ||
import com.google.common.collect.ImmutableSet; | ||
import java.util.List; | ||
import java.util.Map; | ||
import java.util.Set; | ||
import org.apache.gravitino.authorization.Privilege; | ||
import org.apache.gravitino.authorization.ranger.RangerPrivilege.RangerHivePrivilege; | ||
import org.apache.gravitino.authorization.ranger.reference.RangerDefines.PolicyResource; | ||
|
||
public class RangerAuthorizationHivePlugin extends RangerAuthorizationPlugin { | ||
private static volatile RangerAuthorizationHivePlugin instance = null; | ||
|
||
private RangerAuthorizationHivePlugin(Map<String, String> config) { | ||
super(config); | ||
} | ||
|
||
public static synchronized RangerAuthorizationHivePlugin getInstance(Map<String, String> config) { | ||
if (instance == null) { | ||
synchronized (RangerAuthorizationHivePlugin.class) { | ||
if (instance == null) { | ||
instance = new RangerAuthorizationHivePlugin(config); | ||
} | ||
} | ||
} | ||
return instance; | ||
} | ||
|
||
/** Set the default mapping Gravitino privilege name to the Ranger rule */ | ||
public Map<Privilege.Name, Set<RangerPrivilege>> privilegesMappingRule() { | ||
return ImmutableMap.of( | ||
Privilege.Name.CREATE_SCHEMA, | ||
ImmutableSet.of(RangerHivePrivilege.CREATE), | ||
Privilege.Name.CREATE_TABLE, | ||
ImmutableSet.of(RangerHivePrivilege.CREATE), | ||
Privilege.Name.MODIFY_TABLE, | ||
ImmutableSet.of( | ||
RangerHivePrivilege.UPDATE, RangerHivePrivilege.ALTER, RangerHivePrivilege.WRITE), | ||
Privilege.Name.SELECT_TABLE, | ||
ImmutableSet.of(RangerHivePrivilege.READ, RangerHivePrivilege.SELECT)); | ||
} | ||
|
||
/** Set the default owner rule. */ | ||
public Set<RangerPrivilege> ownerMappingRule() { | ||
return ImmutableSet.of(RangerHivePrivilege.ALL); | ||
} | ||
|
||
/** Set Ranger policy resource rule. */ | ||
public List<String> policyResourceDefinesRule() { | ||
return ImmutableList.of( | ||
PolicyResource.DATABASE.getName(), | ||
PolicyResource.TABLE.getName(), | ||
PolicyResource.COLUMN.getName()); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like all these methods return immutable map or list, if so, I would suggest make them singletons, so that we don't have to create maps or lists for each call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to singleton.