[#4661] improvement(iceberg-rest): Adding License and Notice to the i… #4909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the iceberg-rest-server and gravitino server jars
|
@justinmclean can you help review this PR? Thanks! |
|
The iceberg LICENSE and NOTICE files are probably going to be different from the root gravitino one as the release artifact produced will have different contents, but this is obviously an improvement. |
|
Thanks @justinmclean for the feedback. Change to download LICENSE/NOTICE from iceberg repo and put them under META-INF. |
|
This is not quite right. The content of our LICENSE and NOTICE file would not be the same as the contents for the Apache Iceberg project; it will depend on what ends up in the release artifact. I can take a look and see what those contents should be if you want. |
|
Sure. Thanks @justinmclean. I reverted the last two commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adding license and notice to iceberg-rest-server and gravitino server jars
Why are the changes needed?
Fix: #4661 The release jar should contains LICENSE and NOTICE
Does this PR introduce any user-facing change?
No
How was this patch tested?
Build results attached.
