[#4952] feat(hudi-catalog): add implementation of HMSBackend for Hudi catalog #4942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchades
changed the title
jerryshao
reviewed
Sep 21, 2024
| .put( | ||
| LOCATION, | ||
| PropertyEntry.stringOptionalPropertyEntry( | ||
| LOCATION, "The directory for Hudi dataset storage", false, null, false)) |
There was a problem hiding this comment.
Can we please follow the style to add comment like /* required */ to the input variables.
jerryshao
reviewed
Sep 21, 2024
| .put( | ||
| LOCATION, | ||
| stringImmutablePropertyEntry( | ||
| LOCATION, "The location for Hudi table", false, null, false, false)) |
jerryshao
reviewed
Sep 21, 2024
| c -> | ||
| c.getTables(schemaIdent.name(), "*").stream() | ||
| .map(table -> NameIdentifier.of(namespace, table)) | ||
| .toArray(NameIdentifier[]::new)); |
There was a problem hiding this comment.
Will here list all the tables, not just Hudi table, should we filter out non-hudi table?
jerryshao
reviewed
Sep 21, 2024
Comment on lines
+64
to
+66
| partitioning = HiveTableConverter.getPartitioning(hmsTable); | ||
| sortOrders = HiveTableConverter.getSortOrders(hmsTable); | ||
| distribution = HiveTableConverter.getDistribution(hmsTable); |
There was a problem hiding this comment.
Does Hudi store such information in HMS, is it compatible with Hive table? As I know, for Iceberg, we need some Iceberg APIs to get partitioning, sortOrders, because Iceberg will store such information in it's metadata file, not in HMS, I guess Hudi is similar, can you please confirm this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
support read operations for Hudi catalog HMS backend
Why are the changes needed?
Fix: #4952
Does this PR introduce any user-facing change?
no
How was this patch tested?
UTs added