[#4759] feat(auth-ranger): Use Spark verify Ranger authorization Hive #4948
Conversation
xunliu
force-pushed
the
issue-4759
branch
11 times, most recently
from
bb0092c
to
d399416
Compare
...e-iceberg/src/test/java/org/apache/gravitino/catalog/lakehouse/iceberg/TestIcebergTable.java
Outdated
Show resolved
Hide resolved
xunliu
force-pushed
the
issue-4759
branch
11 times, most recently
from
72789d7
to
dba750d
Compare
xunliu
changed the title
xunliu
force-pushed
the
issue-4759
branch
4 times, most recently
from
dc5a9e9
to
ee98f63
Compare
...e-iceberg/src/test/java/org/apache/gravitino/catalog/lakehouse/iceberg/TestIcebergTable.java
Outdated
Show resolved
Hide resolved
|
|
||
| testImplementation(platform("org.junit:junit-bom:5.9.1")) | ||
| testImplementation("org.junit.jupiter:junit-jupiter") | ||
| val testShadowJar by tasks.registering(ShadowJar::class) { |
There was a problem hiding this comment.
after using ShadowJar, the integration test common jar will include almost all dependences, is it expected?
There was a problem hiding this comment.
The integration-test-comman ShadowJar main use to running MiniGravitino service.
We can expend a single MiniGravitino module in the Gravitino project in the future.
@mchades What do you think?
| @@ -260,6 +260,29 @@ private void initializeWebAppServletContextHandler() { | |||
| servletContextHandler = new WebAppContext(); | |||
|
|
|||
| boolean isUnitTest = System.getenv("GRAVITINO_TEST") != null; | |||
| if (isUnitTest) { | |||
There was a problem hiding this comment.
I'm curious about this change, you relocate the jetty package not exclude it, why couldn't find the jetty class?
| @@ -299,7 +322,7 @@ private void initializeWebAppServletContextHandler() { | |||
| if (warFile.isDirectory()) { | |||
| // Development mode, read from FS | |||
| servletContextHandler.setResourceBase(warFile.getPath()); | |||
| servletContextHandler.setContextPath("/"); | |||
| servletContextHandler.addServlet(DefaultServlet.class, "/"); | |||
There was a problem hiding this comment.
We use a web.xml to initial the servletContextHandler. So need change this line.
| testImplementation(project(":server")) | ||
| testImplementation(project(":server-common")) | ||
| testImplementation(project(":core")) { | ||
| exclude(group = "org.rocksdb", module = "rocksdbjni") |
There was a problem hiding this comment.
any reason exclude rocksdb? since this is used for test only.
There was a problem hiding this comment.
The rocksdb-xxx.jar have 47MB size, let Shadow jar package very big, and currently we doesn't support rocksdb storage. So I exclude it.
| @@ -73,7 +73,7 @@ public static void setUp() throws Exception { | |||
|
|
|||
| mySQLCatalog = | |||
| new TestCatalog() | |||
| .withCatalogConf(ImmutableMap.of(Catalog.AUTHORIZATION_PROVIDER, "mysql")) | |||
| .withCatalogConf(ImmutableMap.of(Catalog.AUTHORIZATION_PROVIDER, "mysqlTest")) | |||
There was a problem hiding this comment.
use a static variable? since it's shared by different classes.
There was a problem hiding this comment.
Not other place needs to use this static variable.
What changes were proposed in this pull request?
Why are the changes needed?
Fix: #4759
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
CI Passed.