[#4973] improvement(client-java/server): Clear CallerContext in Java Client and Server when call getFileLocation finally
#4974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xloya
force-pushed
the
remove-caller-context-finally
branch
from
5f9854f
to
2d46469
Compare
xloya
changed the title
CallerContext in Java Client and ServerCallerContext in Java Client and Server when call getFileLocation finally
jerryshao
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, after the client completes the
getFileLocationrequest and the server completes thegetFileLocationresponse, the Thread LocalCallerContextis not cleaned up. This may cause the next request to incorrectly report the same information repeatedly when the thread is reused. We should eventually clean up theCallerContext.Why are the changes needed?
Fix: #4973
How was this patch tested?
Add UTs.