Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5477] improvement(cli): display audit information on Catalog, Schema, Table #5509

Merged

Conversation

orenccl
Copy link
Contributor

@orenccl orenccl commented Nov 7, 2024

What changes were proposed in this pull request?

Add the --audit option to display audit information on Catalog, Schema, Table

Why are the changes needed?

This change allows users to retrieve additional audit information on Catalog/Schema/Table, providing more insights.

Close: #5477

Does this PR introduce any user-facing change?

Yes, it adds the --audit option to CommandEntities.CATALOG/SCHEMA/TABLE.

How was this patch tested?

  1. Follow the instructions in the cli README to build the CLI sub-project.
  2. Start the Gravitino Playground.

To test, use a command like the following:

gcli metalake details --metalake metalake_demo --audit
gcli catalog details --metalake metalake_demo --name catalog_postgres --audit
gcli schema details --metalake metalake_demo --name catalog_postgres.hr --audit
gcli table details --metalake metalake_demo --name catalog_postgres.hr.departments --audit

Check that the output matches the expected audit information.

2024-11-08 002032

@orenccl
Copy link
Contributor Author

orenccl commented Nov 7, 2024

It could potentially conflict with this PR (#5476).

@justinmclean
Copy link
Member

Thank you for the PR. It looks good to me; just a couple of minor things to fix.

@justinmclean
Copy link
Member

justinmclean commented Nov 8, 2024

We've merged a couple of the CLI branches, which is why there are some conflicts here. If you could fix them that would be great. If you need any help just ask.

@orenccl orenccl marked this pull request as draft November 8, 2024 05:17
@orenccl orenccl force-pushed the improvement/displayAuditOption_cli branch from d9d33d5 to d85c4dd Compare November 8, 2024 05:17
@orenccl orenccl marked this pull request as ready for review November 8, 2024 05:21
@orenccl
Copy link
Contributor Author

orenccl commented Nov 8, 2024

Done!

Copy link
Member

@justinmclean justinmclean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you contribution

@justinmclean justinmclean merged commit eb3b6db into apache:main Nov 8, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Display audit information on other entities in the Gravitino CLI
2 participants