Skip to content

Commit

Permalink
*) mod_http2: make test_h2_200_17+18 work reliably with
Browse files Browse the repository at this point in the history
    older and newer curl versions. Only a change in logging,
    no function module change.
    Newer curl send a GOAWAY on connection shutdown which
    triggers another code path that the test did not expect.
    Thanks to Rainer Jung for tracking this down.



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1923187 13f79535-47bb-0310-9956-ffa450edef68
  • Loading branch information
icing committed Jan 17, 2025
1 parent 202d006 commit 49c2ee2
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
6 changes: 4 additions & 2 deletions modules/http2/h2_session.c
Original file line number Diff line number Diff line change
Expand Up @@ -363,9 +363,11 @@ static int on_frame_recv_cb(nghttp2_session *ng2s,
else {
ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c1,
H2_SSSN_LOG(APLOGNO(03066), session,
"recv FRAME[%s], frames=%ld/%ld (r/s)"),
"recv FRAME[%s], frames=%ld/%ld (r/s), "
"remote.emitted=%d"),
buffer, (long)session->frames_received,
(long)session->frames_sent);
(long)session->frames_sent,
(int)session->remote.emitted_count);
}
}

Expand Down
6 changes: 4 additions & 2 deletions test/modules/http2/test_200_header_invalid.py
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,8 @@ def test_h2_200_17(self, env):
conf.add_vhost_cgi()
conf.install()
assert env.apache_restart() == 0
re_emitted = re.compile(r'.* AH03401: .* shutdown, remote.emitted=1')
re_emitted = re.compile(r'.* (AH03401: .* shutdown,|'
r'AH03066: .* FRAME\[GOAWAY.*) remote.emitted=1')
url = env.mkurl("https", "cgi", "/")
opt = []
for i in range(10):
Expand All @@ -263,7 +264,8 @@ def test_h2_200_18(self, env):
conf.add_vhost_cgi()
conf.install()
assert env.apache_restart() == 0
re_emitted = re.compile(r'.* AH03401: .* shutdown, remote.emitted=1')
re_emitted = re.compile(r'.* (AH03401: .* shutdown,|'
r'AH03066: .* FRAME\[GOAWAY.*) remote.emitted=1')
url = env.mkurl("https", "cgi", "/")
opt = []
for i in range(100):
Expand Down

0 comments on commit 49c2ee2

Please sign in to comment.