core: error_log: better handle invalid error log file name #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's an invalid string? Can it be reached via configuration? |
|
I have the fuzzer corpus on my harddrive, i can send it to you directly or maybe upload somewhere |
covener
suggested changes
Jan 6, 2025
server/core.c
Outdated
| char *dir; | ||
| apr_finfo_t finfo; | ||
| apr_status_t rv; | ||
|
|
There was a problem hiding this comment.
why broader scope for these if still used only within the else?
server/core.c
Outdated
| apr_status_t rv = apr_stat(&finfo, dir, APR_FINFO_TYPE, p); | ||
| if (!abs) { | ||
| ap_log_error(APLOG_MARK, APLOG_STARTUP|APLOG_EMERG, 0, | ||
| ap_server_conf, APLOGNO(02291) |
There was a problem hiding this comment.
should be APLOGNO()initially and then can be filled in after committed.
| if (!abs) { | ||
| ap_log_error(APLOG_MARK, APLOG_STARTUP|APLOG_EMERG, 0, | ||
| ap_server_conf, APLOGNO(02291) | ||
| "Cannot construct error log file path '%s'", s->error_fname); |
There was a problem hiding this comment.
can you include the input that triggers this? Hopefully in a way as simple as httpd.conf content rather than calling these functions directly.
if error log file name is an invalid string, ap_server_root_relative will return NULL, which will result in SIGSEGV in ap_make_dirstr_parent
thomasmey
force-pushed
the
bugfix/ap_config_fuzzing3
branch
from
2a91c15 to
448cea2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if error log file name is an invalid string, ap_server_root_relative will return NULL, which will result in SIGSEGV in ap_make_dirstr_parent