Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: enforce Python code style #101

Merged
merged 4 commits into from
Aug 7, 2024
Merged

style: enforce Python code style #101

merged 4 commits into from
Aug 7, 2024

Conversation

muyihao
Copy link
Contributor

@muyihao muyihao commented Jul 28, 2024 •
edited by xushiyan
Loading

Description

  • Add Ruff and MyPy configurations to pyproject.toml
  • Integrate Python linting in GitHub Actions
  • Format python code with lint

Related Issue:
Closes #5

How are the changes test-covered

  • N/A
  • Automated tests (unit and/or integration tests)
  • Manual tests
    • Details are described below

@github-actions github-actions bot added the python Related to Python codebase label Jul 28, 2024
@muyihao muyihao marked this pull request as ready for review July 28, 2024 11:25
@muyihao muyihao mentioned this pull request Jul 28, 2024
Closed
4 tasks
@muyihao muyihao force-pushed the style/enforce-python-code-style branch 2 times, most recently from 4951044 to 1daae3f Compare July 28, 2024 14:11
@codecov Codecov
Copy link

codecov bot commented Jul 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.24%. Comparing base (7566337) to head (628baae).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #101   +/-   ##
=======================================
  Coverage   87.24%   87.24%           
=======================================
  Files          14       14           
  Lines         690      690           
=======================================
  Hits          602      602           
  Misses         88       88

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xushiyan xushiyan added this to the release-0.2.0 milestone Jul 30, 2024
@xushiyan
style: enforce python code style (apache#5)
b545ce2 
- Add Ruff and MyPy configurations to pyproject.toml
- Integrate Python linting in GitHub Actions
- Format code with Ruff and Ruff Format
@xushiyan xushiyan force-pushed the style/enforce-python-code-style branch from 1daae3f to b545ce2 Compare July 30, 2024 05:23
xushiyan
xushiyan approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@xushiyan xushiyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

➜ make check-python
--- Check Python format ---
--- Check Python linting ---
--- Check Python typing ---
ruff format --check --diff .
5 files already formatted
ruff check .
All checks passed!
mypy .
Success: no issues found in 2 source files

@xushiyan xushiyan mentioned this pull request Aug 7, 2024
Closed
@xushiyan xushiyan merged commit f75f12d into apache:main Aug 7, 2024
11 checks passed
@xushiyan xushiyan mentioned this pull request Nov 22, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xushiyan xushiyan xushiyan approved these changes

Assignees
No one assigned
Labels
python Related to Python codebase
Projects
None yet
Milestone
release-0.2.0
Development

Successfully merging this pull request may close these issues.

Enforce Python code style
2 participants
@muyihao @xushiyan