Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move Makefile to root directory #283

Merged
merged 4 commits into from
Feb 2, 2025
Merged

Conversation

nakul-py
Copy link
Contributor

@nakul-py nakul-py commented Jan 31, 2025

Description

Refactoring Makefile such that it works under the root dir.

fixes #281

How are the changes test-covered

  • N/A
  • Automated tests (unit and/or integration tests)
  • Manual tests
    • Details are described below

@nakul-py nakul-py requested a review from xushiyan as a code owner January 31, 2025 11:18
.github/workflows/ci.yml Outdated Show resolved Hide resolved
python/Makefile Outdated Show resolved Hide resolved
@nakul-py nakul-py requested a review from xushiyan February 1, 2025 09:44
@xushiyan
Copy link
Member

xushiyan commented Feb 2, 2025

Thanks. All fixed.

@xushiyan xushiyan changed the title Refactoring makefile for root Dir refactor: move makefile to root dir Feb 2, 2025
@xushiyan xushiyan added refactor Code refactoring without any functionality or behavior change dev-x Dev experience: code format, dev tooling, project management labels Feb 2, 2025
@xushiyan xushiyan added this to the release-0.4.0 milestone Feb 2, 2025
Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.14%. Comparing base (6a995e2) to head (758e80e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #283   +/-   ##
=======================================
  Coverage   91.14%   91.14%           
=======================================
  Files          41       41           
  Lines        2101     2101           
=======================================
  Hits         1915     1915           
  Misses        186      186           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xushiyan xushiyan changed the title refactor: move makefile to root dir refactor: move Makefile to root directory Feb 2, 2025
@xushiyan xushiyan merged commit 0ed61f6 into apache:main Feb 2, 2025
10 checks passed
@nakul-py nakul-py deleted the makefile branch February 2, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-x Dev experience: code format, dev tooling, project management refactor Code refactoring without any functionality or behavior change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Makefile such that it works under the root dir
2 participants