Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-8930] Set transaction manager lock requirement based on config #12733

Closed
wants to merge 1 commit into from

Conversation

codope
Copy link
Member

@codope codope commented Jan 29, 2025

Change Logs

  • After removing defaut lock provider in 63ad659, we need to still set a lock for instant time geenration. See changes in HoodieWriteConfig.
  • Lock requirement for transaction manager can change from within a transaction. For example, when a compaction is scheduled during upgrade, the lock requirement is set to false. Make isLockRequired non-final and provide a setter.
  • TransacationManager's isLockRequired is set in BaseHoodieClient#updateColumnsToIndexWithColStats which is called before beginTransaction and then lock requirements are reset after the job within transaction is done.

Impact

Set transaction manager lock requirement based on config

Risk level (write none, low medium or high below)

medium

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:S PR with lines of changes in (10, 100] label Jan 29, 2025
@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@codope
Copy link
Member Author

codope commented Jan 30, 2025

Closing in favor of #12737

@codope codope closed this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S PR with lines of changes in (10, 100]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants