Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Investigate COW failure for null lock provider #12739

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

codope
Copy link
Member

@codope codope commented Jan 30, 2025

Change Logs

[DO NOT MERGE] Investigate COW failure for null lock provider. See #12737 (review) for more context.

Added more debug logs. NPE is coming when transaction manager is attempting to acquire lock for a write (happening after upgrade):

java.lang.NullPointerException
	at java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1645)
	at org.apache.hudi.common.util.ReflectionUtils.getClass(ReflectionUtils.java:51)
	at org.apache.hudi.common.util.ReflectionUtils.loadClass(ReflectionUtils.java:73)
	at org.apache.hudi.client.transaction.lock.LockManager.getLockProvider(LockManager.java:111)
	at org.apache.hudi.client.transaction.lock.LockManager.lambda$lock$20c251e3$1(LockManager.java:80)
	at org.apache.hudi.common.util.RetryHelper.start(RetryHelper.java:94)
	at org.apache.hudi.client.transaction.lock.LockManager.lock(LockManager.java:77)
	at org.apache.hudi.client.transaction.TransactionManager.beginTransaction(TransactionManager.java:58)
	at org.apache.hudi.client.BaseHoodieWriteClient.executeUsingTxnManager(BaseHoodieWriteClient.java:1310)
	at org.apache.hudi.client.BaseHoodieWriteClient.doInitTable(BaseHoodieWriteClient.java:1302)
	at org.apache.hudi.client.BaseHoodieWriteClient.initTable(BaseHoodieWriteClient.java:1352)
	at org.apache.hudi.client.SparkRDDWriteClient.upsert(SparkRDDWriteClient.java:129)
	at org.apache.hudi.DataSourceUtils.doWriteOperation(DataSourceUtils.java:227)
	at org.apache.hudi.HoodieSparkSqlWriterInternal.liftedTree1$1(HoodieSparkSqlWriter.scala:518)
	at org.apache.hudi.HoodieSparkSqlWriterInternal.writeInternal(HoodieSparkSqlWriter.scala:516)
	at org.apache.hudi.HoodieSparkSqlWriterInternal.$anonfun$write$1(HoodieSparkSqlWriter.scala:193)

Impact

Investigation. DO NOT MERGE.

Risk level (write none, low medium or high below)

none

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:S PR with lines of changes in (10, 100] label Jan 30, 2025
@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S PR with lines of changes in (10, 100]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants