Core: Add a util to compute partition stats #11146
Open
+990
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajantha-bhat
commented
Sep 16, 2024
| */ | ||
| package org.apache.iceberg; | ||
|
|
||
| public class PartitionStats implements StructLike { |
There was a problem hiding this comment.
Extends with StructLike as the writers will be writing these objects or wrap this object.
| @@ -100,6 +101,25 @@ public static StructLike coercePartition( | |||
| return projection; | |||
| } | |||
|
|
|||
| public static PartitionData coercePartitionData( | |||
There was a problem hiding this comment.
Just extracted common codes to util instead of duplicating the same.
ajantha-bhat
force-pushed
the
compute_stats_no_lock
branch
from
1fb368c
to
d3982f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced two API's to compute and sort partition stats as per spec.
Iterable<PartitionStats> partitionStats = PartitionStatsUtil.computeStats(table, table.currentSnapshot());PartitionStatsUtil.sortStats(partitionStats, Partitioning.partitionType(table));These will be used by engines integrated with writer to compute and write the partition stats.