Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all plugins to MultiContextDeserializer #457

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Aryant01
Copy link

@Aryant01 Aryant01 commented Aug 6, 2024

I've added two new plugins: Hadoop and GraphChi, and I've also uncommented a previously mentioned plugin. Since I'm new to open source, please let me know if I've missed anything.

Copy link
Contributor

@zkaoudi zkaoudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

we don't have a hadoop and graphchi plugin. Also please double check before doing any PR that all tests pass. This is very important.

@zkaoudi
Copy link
Contributor

zkaoudi commented Aug 8, 2024

Also, the headers are mandatory to all files so you should not have removed it :)

@Aryant01
Copy link
Author

Aryant01 commented Aug 8, 2024

Hi, I apologize for my impatience. I'll make sure to address the bugs and mistakes I've introduced, and I'll be more mindful of testing in the future. Thank you for your patience and assistance.

@2pk03
Copy link
Member

2pk03 commented Aug 8, 2024

Hey @Aryant01,

Great to see you here!

We know it's overwhelming to start working on open source projects, we've all been there! That's why we've put together information to make it easier to contribute => https://wayang.apache.org/docs/community/contribute

We also encourage contributors (yes, you're one now 👍🏾) to join the public mailing lists => https://wayang.apache.org/docs/community/mailinglist.

Keep up the great work and thank you,
@2pk03

@Aryant01
Copy link
Author

Aryant01 commented Aug 8, 2024

Hey @2pk03 ,
Thankyou for your concern. I really appreciate it. I will follow the contribution guide and will be joining the mailing lists.
Thankyou.

@Aryant01
Copy link
Author

Hey @zkaoudi
I am a bit confused about the task.
Do I only have to uncomment the commented plugin in the file i.e. Flink or should I add every plugins in it which is mentioned in pom.xml file? I have mentioned the plugins below. If this is not what I have to do, then can you please guide me a bit more about what I have to do and where can I find the needed plugins? Thankyou so much for your patience. And also I am almost complete with the another task (wanyang-benchmark) you have assigned me. I will post an update for that very soon.

plugins from pom -
clover-maven-plugin
maven-assembly-plugin
maven-antrun-plugin
maven-compiler-plugin
maven-checkstyle-plugin
maven-dependency-plugin
maven-deploy-plugin
maven-enforcer-plugin
maven-failsafe-plugin
maven-jar-plugin
maven-javadoc-plugin
maven-source-plugin
maven-surefire-plugin
build-helper-maven-plugin
artifactory-maven-plugin
maven-site-plugin
groovy-maven-plugin
apache-rat-plugin
license-maven-plugin
maven-remote-resources-plugin
jacoco-maven-plugin
maven-release-plugin

@zkaoudi
Copy link
Contributor

zkaoudi commented Aug 22, 2024

Hi @Aryant01, thank you for your question. I believe it's missing some implementation so that Flink works with the multicontext. Could you try uncommenting that line and check if everything runs correctly?

@Aryant01 Aryant01 requested a review from zkaoudi August 22, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants