MINOR: Log pending join members (#17219)

I am still chasing KAFKA-17493. I was able to narrow it down to an issue with the pending join members. This patch logs them in order to help me troubleshooting it further. I will revert this change when the issue is root caused. Reviewers: David Arthur <[email protected]>
apache · Sep 18, 2024 · 74bebf6 · 74bebf6
1 parent 95b734d
commit 74bebf6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java
@@ -4043,7 +4043,7 @@ private CoordinatorResult<Void, CoordinatorRecord> maybeCompleteJoinPhase(Classi
         if (!group.hasAllMembersJoined()) {
             log.debug("Cannot complete join phase of group {} because not all the members have rejoined. " +
                 "Members={}, AwaitingJoinResponses={}, PendingJoinMembers={}.",
-                group.groupId(), group.numMembers(), group.numAwaitingJoinResponse(), group.numPendingJoinMembers());
+                group.groupId(), group.numMembers(), group.numAwaitingJoinResponse(), String.join(",", group.pendingJoinMembers()));
             return EMPTY_RESULT;
         }
 

diff --git a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/classic/ClassicGroup.java b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/classic/ClassicGroup.java
@@ -609,6 +609,13 @@ public boolean isPendingMember(String memberId) {
         return pendingJoinMembers.contains(memberId);
     }
 
+    /**
+     * @return The set of pending join members.
+     */
+    public Set<String> pendingJoinMembers() {
+        return Collections.unmodifiableSet(pendingJoinMembers);
+    }
+
     /**
      * Add a pending member.
      *