KAFKA-17529: Remove blacklist from MM2 #17202
Open
+17
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chiacyu thanks for your patch. Could you please cleanup the test of Also, please update |
chia7712
reviewed
Sep 17, 2024
docs/upgrade.html
Outdated
| @@ -51,6 +51,18 @@ <h5><a id="upgrade_400_notable" href="#upgrade_400_notable">Notable changes in 4 | |||
| The <code>--whitelist</code> option was removed from the <code>kafka-console-consumer</code> command line tool. | |||
| Please use <code>--include</code> instead. | |||
| </li> | |||
| <li> | |||
| The <code>--whitelist</code> option was removed from the <code>kafka-console-consumer</code> command line tool. | |||
There was a problem hiding this comment.
Please remove this unrelated change
chia7712
reviewed
Sep 19, 2024
| @@ -69,8 +69,8 @@ public void testConfigPropertyMatching() { | |||
| @Test | |||
| public void testConfigBackwardsCompatibility() { | |||
There was a problem hiding this comment.
we don't need this test because the blacklist-related configs are removed, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled, check KAFKA-17529 for details.
Please take a look, thanks!
Committer Checklist (excluded from commit message)