KAFKA-17542: Use actions/labeler for automatic PR labeling

[TaiJuWu]

Jira: https://issues.apache.org/jira/browse/KAFKA-17542

test on TaiJuWu#5

Committer Checklist (excluded from commit message)

• Verify design and implementation
• Verify test coverage and CI build status
• Verify documentation (including upgrade notes)

[mumrah]

raft and metadata aren't labels we currently have. You can check the existing ones here: https://github.com/apache/kafka/labels

[TaiJuWu]

raft and metadata aren't labels we currently have. You can check the existing ones here: https://github.com/apache/kafka/labels

Hi @mumrah , thanks for your review and info!

[chia7712]

@TaiJuWu thanks for this patch I believe it will be an important feature to our PR flow. I list some brainstorming below. PTAL

1. add module labels according to changed files
2. add build/ci label if build.gradle/.github related files are changed
3. add test label if only test code gets changed
4. add minor label if there are few line changes
5. add docs label if only docs get changed

[mumrah]

Left some additional comments, @TaiJuWu.

I like @chia7712's suggestions. For 3 and 4, we may probably will need to do something more complex than simply using the labeler action. For example,

3. add test label if only test code gets changed

will require getting the diff of the PR and checking the file paths. This will require a script of some kind.

[mumrah]

Thanks @TaiJuWu, looks good. One minor suggestion.

If we want to wait on @chia7712's more complex suggestions (i.e., "minor" label and "tests" only PRs), we can do those in a part 2 PR.

[TaiJuWu]

Left some additional comments, @TaiJuWu.

I like @chia7712's suggestions. For 3 and 4, we may probably will need to do something more complex than simply using the labeler action. For example,

3. add test label if only test code gets changed

will require getting the diff of the PR and checking the file paths. This will require a script of some kind.

Yes, you are right, but the action/labeler does not support scripts. I am still investigating how to achieve this goal.
Thanks for your review.

[mumrah]

Yes, you are right, but the action/labeler does not support scripts

We can add an additional step to evaluate the diff and determine what labels to apply. We can use octokit or gh api (my preference) to actually set the label.

[TaiJuWu]

Thanks @TaiJuWu, looks good. One minor suggestion.

If we want to wait on @chia7712's more complex suggestions (i.e., "minor" label and "tests" only PRs), we can do those in a part 2 PR.

Yes, you are right, but the action/labeler does not support scripts

We can add an additional step to evaluate the diff and determine what labels to apply. We can use octokit or gh api (my preference) to actually set the label.

Ok. I am happy to handle this.
Another question, does we need our bot (like apache-bot) intead of github bot if we need to use gh api ?

[mumrah]

Here is an example of using the gh tool within our workflows

https://github.com/apache/kafka/blob/trunk/.github/actions/gh-api-update-status/action.yml

It would be nice to have a reusable action similar to this for adding labels

[TaiJuWu]

Here is an example of using the gh tool within our workflows

https://github.com/apache/kafka/blob/trunk/.github/actions/gh-api-update-status/action.yml

It would be nice to have a reusable action similar to this for adding labels

Got it. Thanks a lot.

[chia7712]

Should we add generator label?

[chia7712]

Also, transaction may need a individual label too.

[chia7712]

Could you add share-related folder?

[TaiJuWu]

Hi @chia7712 ,
All comments are addressed in 80bfa4a
There is a special case share-coordinator, should we put share or coordinator to it?

[mumrah]

Ah, we should use KIP-932 for the share coordinator

[chia7712]

@TaiJuWu thanks for this patch!

[mumrah]

edit: see below

[mumrah]

Actually found a few issues remaining. Can you address these and then I'll merge. We don't need this to be perfect -- just a good starting point 😄

People focusing on specific project areas will be free to modify this config to auto-label things as they see fit.

[TaiJuWu]

Hi @mumrah , all comments are addressed, thanks for review.

[mumrah]

last nit 😄

[mumrah]

nit: transactions (plural)