Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-17767 Automatically quarantine new tests [5/n] #17725

Open
wants to merge 11 commits into
base: trunk
Choose a base branch
from

Conversation

mumrah
Copy link
Contributor

@mumrah mumrah commented Nov 8, 2024

This patch pulls things together to automatically quarantine recently added tests. Changes include

  • Separation of "test" from "quarantinedTest" results. This will make reporting easier in the future.
  • Introduce QuarantinedExecutionCondition to run/skip quarantined tests

@github-actions github-actions bot added the build Gradle build or GitHub Actions label Nov 8, 2024
@mumrah
Copy link
Contributor Author

mumrah commented Nov 12, 2024

I am not 100% happy with the execution condition as a means to skip/run quarantined tests. The current approach results in a lot of SKIPPED tests which is not ideal. I have opened a discussion thread junit-team/junit5#4121 to solicit ideas from the JUnit community.

@@ -564,7 +569,6 @@ subprojects {

useJUnitPlatform {
includeEngines 'junit-jupiter'
includeTags 'flaky'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to selective include newly added test, we can't filter anything at this point.

@mumrah mumrah requested a review from chia7712 November 12, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Gradle build or GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant