Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-18674: Document the incompatible changes in parsing --bootstrap-server #18751

Merged
merged 3 commits into from
Feb 3, 2025
Merged

KAFKA-18674: Document the incompatible changes in parsing --bootstrap-server #18751

merged 3 commits into from
Feb 3, 2025

Conversation

mingyen066
Copy link
Collaborator

@mingyen066 mingyen066 commented Jan 30, 2025 •
edited
Loading

Based on the discussion of #18741 (comment), add the description to docs/upgrade.html

The change in behavior requiring strict validation seems reasonable for 4.0 so we probably ought to mention it in the documentation in docs/upgrade.html.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added triage PRs from the community docs small Small PRs labels Jan 30, 2025
chia7712
chia7712 reviewed Jan 30, 2025
View reviewed changes
@github-actions github-actions bot removed the triage PRs from the community label Jan 31, 2025
@kamalcph kamalcph changed the title KAFKA-18674: Document the incompatible changes in parsing --bootstrap.servers KAFKA-18674: Document the incompatible changes in parsing --bootstrap-server Jan 31, 2025
@chia7712
Copy link
Member

chia7712 commented Feb 3, 2025

@mingyen066 could you please copy the unit test of #18767 to 4.0? the other format should be failed in 4.0

@mingyen066 mingyen066 mentioned this pull request Feb 3, 2025
Merged
3 tasks
@mingyen066
Copy link
Collaborator Author

Hi @chia7712 , absolutely! I've created PR #18781, which includes a unit test for verify invalid format in 4.0. PTAL. Thank you!"

@chia7712 chia7712 merged commit 9d6faf0 into apache:trunk Feb 3, 2025
10 checks passed
chia7712 pushed a commit that referenced this pull request Feb 3, 2025
@mingyen066 @chia7712
KAFKA-18674 Document the incompatible changes in parsing --bootstrap-…
563d729 
…server (#18751)

Reviewers: Chia-Ping Tsai <[email protected]>
@mingyen066 mingyen066 deleted the KAFKA-18674-document-the-incompatible-changes-in-parsing-bootstrap.servers branch February 6, 2025 06:09
pdruley pushed a commit to pdruley/kafka that referenced this pull request Feb 12, 2025
@mingyen066 @pdruley
KAFKA-18674 Document the incompatible changes in parsing --bootstrap-…
dfee10d 
…server (apache#18751)

Reviewers: Chia-Ping Tsai <[email protected]>
manoj-mathivanan pushed a commit to manoj-mathivanan/kafka that referenced this pull request Feb 19, 2025
@mingyen066 @manoj-mathivanan
KAFKA-18674 Document the incompatible changes in parsing --bootstrap-…
3e7fa45 
…server (apache#18751)

Reviewers: Chia-Ping Tsai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chia7712 chia7712 chia7712 approved these changes

Assignees
No one assigned
Labels
ci-approved docs small Small PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mingyen066 @chia7712