MINOR: migrate BrokerCompressionTest to storage module #19277
+111
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
TaiJuWu
changed the title
FrankYang0529
approved these changes
Mar 25, 2025
| /* Configure broker-side compression */ | ||
| UnifiedLog log = UnifiedLog.create( | ||
| logDir, | ||
| new LogConfig(logProps), |
There was a problem hiding this comment.
Can we change this like following, so we don't need logProps?
new LogConfig(Map.of(TopicConfig.COMPRESSION_TYPE_CONFIG, brokerCompressionType.name)),
frankvicky
suggested changes
Mar 25, 2025
Comment on lines
109
to
115
| List<Arguments> args = new ArrayList<>(); | ||
| for (BrokerCompressionType brokerCompression : BrokerCompressionType.values()) { | ||
| for (CompressionType messageCompression : CompressionType.values()) { | ||
| args.add(Arguments.of(messageCompression, brokerCompression)); | ||
| } | ||
| } | ||
| return args.stream(); |
There was a problem hiding this comment.
return Arrays.stream(BrokerCompressionType.values())
.flatMap(brokerCompression -> Arrays.stream(CompressionType.values())
.map(messageCompression -> Arguments.of(messageCompression, brokerCompression)));| return fetchInfo.records.batches().iterator().next(); | ||
| } | ||
|
|
||
| private static Stream<Arguments> parameters() { |
There was a problem hiding this comment.
Please give it a meaningful name.
There was a problem hiding this comment.
I changed the name to allCompressionParameters.
Thanks for suggesting.
m1a2st
reviewed
Mar 25, 2025
| } | ||
| } | ||
|
|
||
| private static RecordBatch readBatch(UnifiedLog log, int offset) throws IOException { |
There was a problem hiding this comment.
The parameter offset is always 0, so I think we can remove it.
Comment on lines
+91
to
+97
| if (brokerCompressionType != BrokerCompressionType.PRODUCER) { | ||
| RecordBatch batch = readBatch(log, 0); | ||
| Compression targetCompression = BrokerCompressionType.targetCompression(log.config().compression, null); | ||
| assertEquals(targetCompression.type(), batch.compressionType(), "Compression at offset 0 should produce " + brokerCompressionType); | ||
| } else { | ||
| assertEquals(messageCompressionType, readBatch(log, 0).compressionType(), "Compression at offset 0 should produce " + messageCompressionType); | ||
| } |
There was a problem hiding this comment.
RecordBatch batch = readBatch(log, 0); can outside the if-else condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two change for this PR.
BrokerCompressionTestfrom core to storageBrokerCompressionTestfrom scala to java