GroovyParserTest: don't clear workdir while indexer is active #8191
+22
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
changed the title
This was referenced Jan 25, 2025
|
planning to merge this after rc2 synced back to master |
fixes sporadic DirectoryNotEmptyExcepton closer look showed that no other groovy tests clear the ws on tearDown(). Lets do the same; ws is cleared on setUp() anyway. NbTestCase: print some more details when recursive clearing fails
mbien
force-pushed
the
stabilize-groovyparsertest
branch
from
bbfaa68 to
85194dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes sporadic
DirectoryNotEmptyExceptoncaused by lucene index being build while the test tries to tear down the workspacecloser look showed that no other groovy tests clear the ws on
tearDown(). Lets do the same; ws is cleared onsetUp()anyway.NbTestCase: print some more details when recursive clearing fails, might help with identifying other concurrent write issuesmeta issue #8183