Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize MultiSourceRootProviderTest #8193

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

mbien
Copy link
Member

@mbien mbien commented Jan 25, 2025

make sure all tasks are done before running classpath queries during test mode.

could reproduce the problem locally, it typically failed once every 5 runs. Ran the test in a loop after this modification and it passed 100 times in a row.

meta issue #8183

@mbien mbien added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) CI continuous integration changes tests labels Jan 25, 2025
@mbien mbien requested a review from lahodaj January 25, 2025 18:22
@mbien mbien added this to the NB26 milestone Jan 25, 2025
Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mbien
Copy link
Member Author

mbien commented Feb 2, 2025

thanks for review, planning to merge this after rc2 synced back to master

make sure all tasks are done before running classpath queries during
test mode.
@mbien mbien force-pushed the stabilize-multisourcerootprovider-test branch from ba902c9 to 380dacf Compare February 7, 2025 16:21
@mbien mbien merged commit 12ad0e7 into apache:master Feb 7, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI continuous integration changes Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants