boards/esp32s3: move QEMU toywasm to different defconfig #15874
+112
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please adhere to Contributing Guidelines.
Summary
This PR creates a separate defconfig for running WebAssembly in QEMU for the ESP32S3.
The extra granularity speeds up the build for most use cases where WebAssembly is not needed.
Also adds
CONFIG_ESP32S3_QEMU_IMAGE=y
to qemu_debug, otherwise QEMU will not be able to run.Impact
Impact on user: New defconfig for using WebAssembly with QEMU.
Impact on build: Speeds up
esp32s3:qemu_debug
. If user requires QEMU with WebAssembly out-of-the-box should now useesp32s3:qemu_toywasm
.Impact on hardware: No.
Impact on documentation: No.
Impact on security: No.
Impact on compatibility: No.
Testing
Building
Build each of the defconfigs normally.
./tools/configure.sh esp32s3-devkit:qemu_debug
or./tools/configure.sh esp32s3-devkit:qemu_toywasm
Running
Test each with QEMU using the following command:
qemu-system-xtensa -nographic -machine esp32s3 -drive file=nuttx.merged.bin,if=mtd,format=raw
Results