Improved: Add permission check for view-maps and change defaults for …

…request-maps (OFBIZ-13130) (#126)

* [Improved]: Add permission check for view-maps and change defaults for
request-maps [(OFBIZ-13130)]

Adds missing view-map parameters in plugins/bi to restore the original
functionality.

* [Improved]: Add permission check for view-maps and change defaults for
request-maps [(OFBIZ-13130)]

Adds missing request- and view-map parameters in plugins/ecommerce to
restore the original functionality.

* [Improved]: Add permission check for view-maps and change defaults for
request-maps [(OFBIZ-13130)]

Adds missing view-map parameters in plugins/example to restore the
original functionality.

* [Improved]: Add permission check for view-maps and change defaults for
request-maps [(OFBIZ-13130)]

Adds missing view-map parameters in plugins/myportal to restore the
original functionality.

* [Improved]: Add permission check for view-maps and change defaults for
request-maps [(OFBIZ-13130)]

Adds missing view-map parameters in plugins/scrum to restore the
original functionality.

* [Improved]: Add permission check for view-maps and change defaults for
request-maps [(OFBIZ-13130)]

Adds missing view-map parameters in plugins/solr to restore the original
functionality.

* [Improved]: Add permission check for view-maps and change defaults for
request-maps [(OFBIZ-13130)]

Adds missing request- and view-map parameters in plugins/webpos to
restore the original functionality.

bi/webapp/bi/WEB-INF/controller.xml

@@ -56,7 +56,7 @@
     <!-- end of request mappings -->
 
     <!-- View Mappings -->
-    <view-map name="main" type="screen" page="component://bi/widget/BiScreens.xml#main"/>
+    <view-map name="main" type="screen" page="component://bi/widget/BiScreens.xml#main" auth="false"/>
 
     <view-map name="ReportBuilderSelectStarSchema" type="screen" page="component://bi/widget/BiScreens.xml#ReportBuilderSelectStarSchema"/>
     <view-map name="ReportBuilderSelectStarSchemaFields" type="screen" page="component://bi/widget/BiScreens.xml#ReportBuilderSelectStarSchemaFields"/>

example/webapp/example/WEB-INF/controller.xml

@@ -273,8 +273,8 @@ under the License.
 
     <!-- ajax view mappings -->
     <view-map name="findExampleAjax" type="screen" page="component://example/widget/example/ExampleAjaxScreens.xml#AjaxExample"/>
-    <view-map name="ListExampleFormOnly" type="screen" page="component://example/widget/example/ExampleAjaxScreens.xml#ListExampleFormOnly"/>
-    <view-map name="CreateExampleFormOnly" type="screen" page="component://example/widget/example/ExampleAjaxScreens.xml#CreateExampleFormOnly"/>
+    <view-map name="ListExampleFormOnly" type="screen" page="component://example/widget/example/ExampleAjaxScreens.xml#ListExampleFormOnly" auth="false"/>
+    <view-map name="CreateExampleFormOnly" type="screen" page="component://example/widget/example/ExampleAjaxScreens.xml#CreateExampleFormOnly" auth="false"/>
     <view-map name="printExampleFOPFonts" type="screenfop" page="component://example/widget/example/FormWidgetExampleScreens.xml#printExampleFOPFonts" content-type="application/pdf"  encoding="none"/>
 
     <view-map name="ExampleGeoLocationPointSet1" type="screen" page="component://example/widget/example/ExampleScreens.xml#ExampleGeoLocationPointSet1"/>

myportal/webapp/myportal/WEB-INF/controller.xml

@@ -85,7 +85,7 @@
 
     <view-map name="main" type="screen" page="component://common/widget/PortalPageScreens.xml#showPortalPage"/>
     <view-map name="login" type="screen" page="component://myportal/widget/CommonScreens.xml#login"/>
-    <view-map name="newRegisterLogin" type="screen" page="component://myportal/widget/CommonScreens.xml#newRegisterLogin"/>  
+    <view-map name="newRegisterLogin" type="screen" page="component://myportal/widget/CommonScreens.xml#newRegisterLogin" auth="false"/>
 
     <view-map name="LookupUserLoginAndPartyDetails" type="screen" page="component://party/widget/partymgr/LookupScreens.xml#LookupUserLoginAndPartyDetails"/>
 

scrum/webapp/demotest/WEB-INF/controller.xml

@@ -36,5 +36,5 @@ under the License.
         <response name="error" type="view" value="main" />
     </request-map>
 
-    <view-map name="main" type="screen" page="component://scrum/widget/demotest/DemotestScreen.xml#main" />
+    <view-map name="main" type="screen" page="component://scrum/widget/demotest/DemotestScreen.xml#main" auth="false"/>
 </site-conf>

solr/webapp/solr/WEB-INF/controller.xml

@@ -59,6 +59,6 @@ under the License.
     </request-map>
 
     <!-- view-maps -->
-    <view-map name="main" type="screen" page="component://solr/widget/SolrScreens.xml#Main"/>
+    <view-map name="main" type="screen" page="component://solr/widget/SolrScreens.xml#Main" auth="false"/>
 
 </site-conf>

webpos/webapp/webpos/WEB-INF/controller.xml

@@ -99,7 +99,7 @@
     <!-- Common json reponse events, chain these after events to send json reponses -->
     <!-- Standard json response, For security reason (OFBIZ-5409) tries to keep only the initially called service attributes -->
     <request-map uri="json">
-        <security direct-request="false"/>
+        <security https="false" auth="false" direct-request="false"/>
         <event type="java" path="org.apache.ofbiz.common.CommonEvents" invoke="jsonResponseFromRequestAttributes"/>
         <response name="success" type="none"/>
     </request-map>
@@ -502,19 +502,19 @@
         <response name="error" type="request" value="js"/>
     </request-map>
     <request-map uri="js">
-        <security direct-request="false"/>
+        <security https="false" auth="false" direct-request="false"/>
         <event type="java" path="org.apache.ofbiz.common.CommonEvents" invoke="jsResponseFromRequest"/>
         <response name="success" type="none"/>
     </request-map>
 
     <!-- View Mappings -->
-    <view-map name="error" type="ftl" page="component://common/webcommon/error/Error.ftl"/>
-    <view-map name="Error" type="screen" page="component://webpos/widget/WebPosScreens.xml#Main"/>
-    <view-map name="main" type="screen" page="component://webpos/widget/WebPosScreens.xml#Main"/>
-    <view-map name="login" type="screen" page="component://webpos/widget/CommonScreens.xml#Login"/>
-    <view-map name="Login" type="screen" page="component://webpos/widget/CommonScreens.xml#Login"/>
-    <view-map name="RequirePasswordChange" type="screen" page="component://webpos/widget/CommonScreens.xml#RequirePasswordChange"/>
-    <view-map name="ListLocales" type="screen" page="component://common/widget/LookupScreens.xml#ListLocales"/>
+    <view-map name="error" type="ftl" page="component://common/webcommon/error/Error.ftl" auth="false"/>
+    <view-map name="Error" type="screen" page="component://webpos/widget/WebPosScreens.xml#Main" auth="false"/>
+    <view-map name="main" type="screen" page="component://webpos/widget/WebPosScreens.xml#Main" auth="false"/>
+    <view-map name="login" type="screen" page="component://webpos/widget/CommonScreens.xml#Login" auth="false"/>
+    <view-map name="Login" type="screen" page="component://webpos/widget/CommonScreens.xml#Login" auth="false"/>
+    <view-map name="RequirePasswordChange" type="screen" page="component://webpos/widget/CommonScreens.xml#RequirePasswordChange" auth="false"/>
+    <view-map name="ListLocales" type="screen" page="component://common/widget/LookupScreens.xml#ListLocales" auth="false"/>
     <view-map name="ListTimezones" type="screen" page="component://common/widget/LookupScreens.xml#ListTimezones"/>
     <view-map name="ListVisualThemes" type="screen" page="component://common/widget/LookupScreens.xml#ListVisualThemes"/>
     <view-map name="help" type="screen" page="component://common/widget/CommonScreens.xml#help"/>
@@ -529,7 +529,7 @@
     <view-map name="SearchSalesRepsList" type="screen" page="component://webpos/widget/SearchScreens.xml#SearchSalesRepsList"/>
     <view-map name="SideDeepCategory" type="screen" page="component://webpos/widget/CatalogScreens.xml#SideDeepCategory"/>
     <view-map name="CategoryDetail" type="screen" page="component://webpos/widget/CatalogScreens.xml#CategoryDetail"/>
-    <view-map name="ForgotPassword_step1" type="screen" page="component://webpos/widget/CommonScreens.xml#ForgotPassword_step1"/>
-    <view-map name="ForgotPassword_step2" type="screen" page="component://webpos/widget/CommonScreens.xml#ForgotPassword_step2"/>
+    <view-map name="ForgotPassword_step1" type="screen" page="component://webpos/widget/CommonScreens.xml#ForgotPassword_step1" auth="false"/>
+    <view-map name="ForgotPassword_step2" type="screen" page="component://webpos/widget/CommonScreens.xml#ForgotPassword_step2" auth="false"/>
     <!-- End of View Mappings -->
 </site-conf>