Fix segment completion FSM on uploaded segment #15062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #15062 +/- ##
============================================
+ Coverage 61.75% 63.34% +1.59%
- Complexity 207 1481 +1274
============================================
Files 2436 2732 +296
Lines 133233 153596 +20363
Branches 20636 23724 +3088
============================================
+ Hits 82274 97294 +15020
- Misses 44911 48945 +4034
- Partials 6048 7357 +1309
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangfu0
approved these changes
Feb 14, 2025
zeronerdzerogeekzerocool
pushed a commit
to zeronerdzerogeekzerocool/pinot
that referenced
this pull request
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14786
When a recently committed segment got replaced by a minion task (e.g. upsert compaction), the segment status is set to UPLOADED. Segment completion FSM should handle UPLOADED segment similar to DONE segment, and treat it as committed.