Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BrokerGrpcServer for a streaming response fetching endpoint #15088

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xiangfu0
Copy link
Contributor

  • Add BrokerGrpcServer which is a grpc based broker query endpoint
  • Add Grpc client support in pinot-java-client with only broker list as the constructor
  • In integration tests, randomly pick grpc or http for sending queries

@xiangfu0 xiangfu0 marked this pull request as draft February 19, 2025 10:57
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 11.08247% with 345 lines in your changes missing coverage. Please review.

Project coverage is 63.28%. Comparing base (59551e4) to head (d2531f7).
Report is 1746 commits behind head on master.

Files with missing lines Patch % Lines
...org/apache/pinot/broker/grpc/BrokerGrpcServer.java 16.18% 140 Missing and 5 partials ⚠️
...a/org/apache/pinot/client/grpc/GrpcConnection.java 0.00% 94 Missing ⚠️
...he/pinot/broker/grpc/BrokerGrpcRequestBuilder.java 0.00% 38 Missing ⚠️
...pache/pinot/broker/grpc/GrpcRequesterIdentity.java 0.00% 32 Missing ⚠️
...pache/pinot/client/grpc/GrpcPreparedStatement.java 0.00% 27 Missing ⚠️
...ain/java/org/apache/pinot/spi/utils/JsonUtils.java 0.00% 6 Missing ⚠️
...ava/org/apache/pinot/client/ConnectionFactory.java 0.00% 1 Missing ⚠️
...g/apache/pinot/common/response/BrokerResponse.java 0.00% 1 Missing ⚠️
...va/org/apache/pinot/spi/utils/CommonConstants.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #15088      +/-   ##
============================================
+ Coverage     61.75%   63.28%   +1.53%     
- Complexity      207     1481    +1274     
============================================
  Files          2436     2751     +315     
  Lines        133233   154708   +21475     
  Branches      20636    23844    +3208     
============================================
+ Hits          82274    97903   +15629     
- Misses        44911    49409    +4498     
- Partials       6048     7396    +1348     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.25% <11.08%> (+1.54%) ⬆️
java-21 63.16% <11.08%> (+1.54%) ⬆️
skip-bytebuffers-false 63.27% <11.08%> (+1.52%) ⬆️
skip-bytebuffers-true 63.14% <11.08%> (+35.42%) ⬆️
temurin 63.28% <11.08%> (+1.53%) ⬆️
unittests 63.27% <11.08%> (+1.53%) ⬆️
unittests1 56.03% <52.94%> (+9.14%) ⬆️
unittests2 33.89% <11.08%> (+6.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangfu0 xiangfu0 force-pushed the grpc-query-client branch 5 times, most recently from 91190e6 to efc40d4 Compare February 20, 2025 20:38
@xiangfu0 xiangfu0 marked this pull request as ready for review February 25, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants