Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make KafkaConsumerFactory compatible with multi-topics ingestion #15094

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lnbest0707-uber
Copy link
Contributor

bugfix

The previous change on

return createPartitionLevelConsumer(clientId, partitionGroupConsumptionStatus.getStreamPartitionGroupId());
would not take effect if the default KafkaConsumerFactory is being used. The function has been override in children classes.

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.39%. Comparing base (59551e4) to head (0296318).
Report is 1738 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #15094      +/-   ##
============================================
+ Coverage     61.75%   63.39%   +1.63%     
- Complexity      207     1482    +1275     
============================================
  Files          2436     2744     +308     
  Lines        133233   154078   +20845     
  Branches      20636    23781    +3145     
============================================
+ Hits          82274    97673   +15399     
- Misses        44911    49026    +4115     
- Partials       6048     7379    +1331     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.35% <100.00%> (+1.64%) ⬆️
java-21 63.27% <100.00%> (+1.65%) ⬆️
skip-bytebuffers-false 63.38% <100.00%> (+1.63%) ⬆️
skip-bytebuffers-true 63.25% <100.00%> (+35.52%) ⬆️
temurin 63.39% <100.00%> (+1.63%) ⬆️
unittests 63.38% <100.00%> (+1.64%) ⬆️
unittests1 56.03% <ø> (+9.14%) ⬆️
unittests2 33.88% <100.00%> (+6.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants