Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emits lag metric when caught up #15102

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

noob-se7en
Copy link
Contributor

When Partition Consumer is caught up, Server does not emit any lag metric.
This fails some alert promQL expressions. The metric must be zero for such cases.

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.46%. Comparing base (59551e4) to head (d957743).
Report is 1750 commits behind head on master.

Files with missing lines Patch % Lines
...e/data/manager/realtime/IngestionDelayTracker.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #15102      +/-   ##
============================================
+ Coverage     61.75%   63.46%   +1.71%     
- Complexity      207     1481    +1274     
============================================
  Files          2436     2745     +309     
  Lines        133233   154310   +21077     
  Branches      20636    23806    +3170     
============================================
+ Hits          82274    97936   +15662     
- Misses        44911    48984    +4073     
- Partials       6048     7390    +1342     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.39% <50.00%> (+1.69%) ⬆️
java-21 63.36% <50.00%> (+1.73%) ⬆️
skip-bytebuffers-false 63.45% <50.00%> (+1.71%) ⬆️
skip-bytebuffers-true 63.29% <50.00%> (+35.56%) ⬆️
temurin 63.46% <50.00%> (+1.71%) ⬆️
unittests 63.46% <50.00%> (+1.71%) ⬆️
unittests1 56.03% <50.00%> (+9.14%) ⬆️
unittests2 33.99% <0.00%> (+6.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gortiz gortiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, but we made several mistakes in the past, so I would let @KKcorps or @Jackie-Jiang take the last call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants