Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Query Resource Isolation] Workload Configs #15109

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

praveenc7
Copy link
Contributor

@praveenc7 praveenc7 commented Feb 21, 2025

Add Workload Configs to be used for query resource isolation

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 36.11111% with 46 lines in your changes missing coverage. Please review.

Project coverage is 56.04%. Comparing base (59551e4) to head (8cba504).
Report is 1751 commits behind head on master.

Files with missing lines Patch % Lines
...ache/pinot/common/metadata/ZKMetadataProvider.java 0.00% 27 Missing ⚠️
...ache/pinot/spi/config/workload/WorkloadConfig.java 53.84% 6 Missing ⚠️
...pinot/common/utils/config/WorkloadConfigUtils.java 58.33% 5 Missing ⚠️
.../pinot/spi/config/workload/EnforcementProfile.java 60.00% 4 Missing ⚠️
...apache/pinot/spi/config/workload/WorkloadCost.java 60.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (59551e4) and HEAD (8cba504). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (59551e4) HEAD (8cba504)
skip-bytebuffers-false 7 6
unittests 5 3
java-11 5 4
unittests2 3 0
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #15109      +/-   ##
============================================
- Coverage     61.75%   56.04%   -5.71%     
- Complexity      207      802     +595     
============================================
  Files          2436     2154     -282     
  Lines        133233   115688   -17545     
  Branches      20636    18587    -2049     
============================================
- Hits          82274    64834   -17440     
- Misses        44911    45545     +634     
+ Partials       6048     5309     -739     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 56.00% <36.11%> (-5.70%) ⬇️
java-21 55.90% <36.11%> (-5.72%) ⬇️
skip-bytebuffers-false 56.03% <36.11%> (-5.72%) ⬇️
skip-bytebuffers-true 55.84% <36.11%> (+28.12%) ⬆️
temurin 56.04% <36.11%> (-5.71%) ⬇️
unittests 56.03% <36.11%> (-5.71%) ⬇️
unittests1 56.03% <36.11%> (+9.14%) ⬆️
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants