Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft]Add a new distinctCountGlobal function #15117

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Feb 24, 2025

Add a new distinctCountGlobal function to implement a sharable ConcurrentHashMap to update distinct values to avoid many hashset merges. This is much faster for large distinct counts queries

…rentHashMap to update distinct values to avoid many hashset merges. This is much faster for large distinct counts queries
@xiangfu0 xiangfu0 marked this pull request as draft February 24, 2025 13:01
@xiangfu0 xiangfu0 changed the title Add a new distinctCountGlobal function to implement a sharable Concur… [draft]Add a new distinctCountGlobal function Feb 24, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 26.80412% with 142 lines in your changes missing coverage. Please review.

Project coverage is 63.38%. Comparing base (59551e4) to head (0291849).
Report is 1753 commits behind head on master.

Files with missing lines Patch % Lines
...nction/DistinctCountGlobalAggregationFunction.java 0.00% 116 Missing ⚠️
...e/operator/combine/AggregationCombineOperator.java 67.12% 14 Missing and 10 partials ⚠️
...org/apache/pinot/core/common/ObjectSerDeUtils.java 66.66% 0 Missing and 1 partial ⚠️
...gregation/function/AggregationFunctionFactory.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #15117      +/-   ##
============================================
+ Coverage     61.75%   63.38%   +1.63%     
- Complexity      207     1480    +1273     
============================================
  Files          2436     2749     +313     
  Lines        133233   154635   +21402     
  Branches      20636    23838    +3202     
============================================
+ Hits          82274    98013   +15739     
- Misses        44911    49211    +4300     
- Partials       6048     7411    +1363     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.36% <26.80%> (+1.65%) ⬆️
java-21 63.26% <26.80%> (+1.63%) ⬆️
skip-bytebuffers-false 63.36% <26.80%> (+1.61%) ⬆️
skip-bytebuffers-true 63.26% <26.80%> (+35.53%) ⬆️
temurin 63.38% <26.80%> (+1.63%) ⬆️
unittests 63.37% <26.80%> (+1.63%) ⬆️
unittests1 55.97% <26.80%> (+9.07%) ⬆️
unittests2 33.95% <0.00%> (+6.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants