The delete function behaviour for GCSPinotFS is different from that of S3PinotFS, LocalPinotFS. #15123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15123 +/- ##
============================================
+ Coverage 61.75% 63.46% +1.71%
- Complexity 207 1480 +1273
============================================
Files 2436 2748 +312
Lines 133233 154441 +21208
Branches 20636 23816 +3180
============================================
+ Hits 82274 98018 +15744
- Misses 44911 49029 +4118
- Partials 6048 7394 +1346
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
swaminathanmanish
approved these changes
Feb 25, 2025
…PinotFS, LocalPinotFS. Align it for the case when the directory or file is missing i.e. return false for delete irrespective of the forceDelete flag.
9aman
force-pushed
the
fixing_different_behaviour_for_gcs_fs
branch
from
7ee7e71 to
eb23bfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
GCS pinot FS returns
truewhile trying to delete a directory/ file even when the directory/ file does not exist, when the forceDelete flag is set totrue.This behavior is wrong and is different from that of S3PinotFS and LocalPinotFS, that return false in case the directory/ file is missing irrespective of the forceDelete flag value.
Fix
Align GCSPinotFS for the case when the directory or file is missing i.e. return false for delete irrespective of the forceDelete flag
Any impact on functionality of other functions of the interface ?
This function is currently used by
doMove. doMove ensures the existence of the file before performing the move from source to destination. The above change in delete should not impact it.