Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Initialize UrlServiceProvider before trying to use transaction coordinator #23914

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

merlimat
Copy link
Contributor

Motivation

When transaction client is enabled, it gets initialized before the ServiceUrlProvider does get a chance to get initialized.

If the URL depends on a probe in the ServiceUrlProvider, the txn coordinator client is still going to use the default URL instead of getting an updated URL by the probe.

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 30, 2025
@merlimat merlimat changed the title Initialize UrlServiceProvider before trying to use transaction coordinator [fix] Initialize UrlServiceProvider before trying to use transaction coordinator Jan 30, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.23%. Comparing base (bbc6224) to head (5466479).
Report is 878 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23914      +/-   ##
============================================
+ Coverage     73.57%   74.23%   +0.66%     
+ Complexity    32624    31803     -821     
============================================
  Files          1877     1853      -24     
  Lines        139502   143737    +4235     
  Branches      15299    16339    +1040     
============================================
+ Hits         102638   106704    +4066     
+ Misses        28908    28632     -276     
- Partials       7956     8401     +445     
Flag Coverage Δ
inttests 26.73% <33.33%> (+2.14%) ⬆️
systests 23.20% <33.33%> (-1.12%) ⬇️
unittests 73.75% <100.00%> (+0.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...g/apache/pulsar/client/impl/ClientBuilderImpl.java 86.30% <100.00%> (+0.32%) ⬆️
...rg/apache/pulsar/client/impl/PulsarClientImpl.java 75.20% <100.00%> (+0.90%) ⬆️

... and 1032 files with indirect coverage changes

@merlimat merlimat merged commit cdab2d6 into apache:master Jan 31, 2025
55 of 57 checks passed
merlimat added a commit that referenced this pull request Jan 31, 2025
merlimat added a commit that referenced this pull request Jan 31, 2025
@merlimat merlimat deleted the fix-txn-init branch January 31, 2025 02:29
@merlimat merlimat added this to the 4.1.0 milestone Jan 31, 2025
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jan 31, 2025
lhotari pushed a commit that referenced this pull request Jan 31, 2025
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Feb 3, 2025
nodece pushed a commit to ascentstream/pulsar that referenced this pull request Feb 10, 2025
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
nodece pushed a commit to ascentstream/pulsar that referenced this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants