Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] PIP-406: Introduce pulsar_subscription_dispatch_throttled_msgs and bytes metrics #23946

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shibd
Copy link
Member

@shibd shibd commented Feb 7, 2025

Motivation

Refer to #23945

Modifications

  1. Maintain dispatchThrottledMsgs and dispatchThrottledBytes in AbstractBaseDispatcher. Increase these values whenever the number of messages/bytes is reduced during calculateToRead.
  2. Output these fields when retrieving topic stats and metrics.

Verifying this change

  • Add testSubscriptionStatsDispatchThrottled to cover it

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@shibd shibd added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/metrics ready-to-test labels Feb 7, 2025
@shibd shibd self-assigned this Feb 7, 2025
@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics doc-required Your PR changes impact docs and you will update later. ready-to-test type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant