-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat][client] Support forward proxy for the ZTS server in pulsar-client-auth-athenz #23947
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23947 +/- ##
============================================
+ Coverage 73.57% 74.23% +0.65%
+ Complexity 32624 31877 -747
============================================
Files 1877 1853 -24
Lines 139502 143743 +4241
Branches 15299 16337 +1038
============================================
+ Hits 102638 106705 +4067
+ Misses 28908 28621 -287
- Partials 7956 8417 +461
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…ent-auth-athenz (apache#23947) (cherry picked from commit 54e9eb1)
Motivation
When we can only access the Athenz ZTS server through a forward proxy, we can't use pulsar-client-auth-athenz for an authentication plugin because the current plugin implementation does not support the ztsProxyUrl config of ZTSClient.
Modifications
Support ztsProxyUrl in the pulsar-client-auth-athenz.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: equanz#12