Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat][client] Support forward proxy for the ZTS server in pulsar-client-auth-athenz #23947

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

equanz
Copy link
Contributor

@equanz equanz commented Feb 7, 2025

Motivation

When we can only access the Athenz ZTS server through a forward proxy, we can't use pulsar-client-auth-athenz for an authentication plugin because the current plugin implementation does not support the ztsProxyUrl config of ZTSClient.

Modifications

Support ztsProxyUrl in the pulsar-client-auth-athenz.

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • Added an unit test for ztsProxyUrl config

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: equanz#12

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.23%. Comparing base (bbc6224) to head (5a56563).
Report is 886 commits behind head on master.

Files with missing lines Patch % Lines
.../pulsar/client/impl/auth/AuthenticationAthenz.java 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23947      +/-   ##
============================================
+ Coverage     73.57%   74.23%   +0.65%     
+ Complexity    32624    31877     -747     
============================================
  Files          1877     1853      -24     
  Lines        139502   143743    +4241     
  Branches      15299    16337    +1038     
============================================
+ Hits         102638   106705    +4067     
+ Misses        28908    28621     -287     
- Partials       7956     8417     +461     
Flag Coverage Δ
inttests 26.65% <ø> (+2.07%) ⬆️
systests 23.24% <ø> (-1.08%) ⬇️
unittests 73.74% <80.00%> (+0.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../pulsar/client/impl/auth/AuthenticationAthenz.java 64.03% <80.00%> (+4.57%) ⬆️

... and 1036 files with indirect coverage changes

@nodece nodece merged commit 54e9eb1 into apache:master Feb 8, 2025
65 of 67 checks passed
@equanz equanz deleted the add_zts_proxy_url branch February 8, 2025 11:05
lhotari pushed a commit that referenced this pull request Feb 8, 2025
lhotari pushed a commit that referenced this pull request Feb 8, 2025
nodece pushed a commit to ascentstream/pulsar that referenced this pull request Feb 10, 2025
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants