Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(operator): add-pressure-exec replace job(get pod log) #358

Merged
merged 1 commit into from
May 15, 2023

Conversation

moomman
Copy link
Contributor

@moomman moomman commented May 10, 2023

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance

What this PR does / why we need it:

  1. add pressureCfg spec for pressure-exec
  2. change status Msg to express steady And chaos experiment

Pre-submission checklist:

@github-actions github-actions bot added the operator solutions of operator label May 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2023

Codecov Report

Merging #358 (96a9645) into main (6c3683b) will decrease coverage by 3.52%.
The diff coverage is 11.21%.

❗ Current head 96a9645 differs from pull request most recent head bd0378b. Consider uploading reports for the commit bd0378b to get more accurate results

@@            Coverage Diff             @@
##             main     #358      +/-   ##
==========================================
- Coverage   45.74%   42.22%   -3.52%     
==========================================
  Files          47       45       -2     
  Lines        5032     4710     -322     
==========================================
- Hits         2302     1989     -313     
- Misses       2561     2568       +7     
+ Partials      169      153      -16     
Impacted Files Coverage Δ
...ator/cmd/shardingsphere-operator/manager/option.go 46.42% <0.00%> (-0.42%) ⬇️
...pkg/controllers/shardingsphere_chaos_controller.go 0.00% <0.00%> (ø)
shardingsphere-operator/pkg/pressure/pressure.go 0.00% <0.00%> (ø)
...e-operator/pkg/reconcile/storagenode/aws/aurora.go 0.00% <0.00%> (ø)
...here-operator/pkg/reconcile/storagenode/aws/aws.go 0.00% <ø> (ø)
...perator/pkg/controllers/storage_node_controller.go 40.65% <17.75%> (-27.37%) ⬇️
...rator/pkg/reconcile/storagenode/aws/rdsinstance.go 22.46% <26.76%> (+6.46%) ⬆️
pitr/cli/pkg/httputils/req.go 21.91% <69.23%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mlycore mlycore added in: chaos modules of shardingsphere chaos type: feature labels May 10, 2023
@mlycore mlycore added this to the 0.3.0 milestone May 10, 2023
@moomman moomman force-pushed the add-pressure-exec branch 15 times, most recently from 593e912 to 7d6fc41 Compare May 12, 2023 10:08
@Xu-Wentao
Copy link
Collaborator

add more meaningful test to cover your core func like exec pressure

@moomman moomman force-pushed the add-pressure-exec branch 2 times, most recently from 14e5922 to b63f5e4 Compare May 15, 2023 03:50
@sonarcloud
Copy link

sonarcloud bot commented May 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@Xu-Wentao Xu-Wentao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mlycore mlycore merged commit 8e895b9 into apache:main May 15, 2023
@moomman moomman deleted the add-pressure-exec branch May 15, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: chaos modules of shardingsphere chaos operator solutions of operator type: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants