Add NavigableObject.wrap. Deprecate MapWriter.EMPTY and MapWriterMap. #3148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will merge in a few days. |
dsmiley
added a commit
that referenced
this pull request
Feb 12, 2025
…#3148) Introduce NavigableObject.wrap to coerce its arg to a NavigableObject. Deprecate MapWriter.EMPTY; don't need it anymore (due to the above); was only used once. Enhance Utils to not need MapWriterMap for its functions, and to slightly optimize for SimpleOrderedMap now being a Map. Deprecate MapWriterMap. Ultimately may simply make package scope and maybe rename to orient itself around its NavigableObject-ness, which is what it's only used for, after the changes here. (cherry picked from commit d911c1a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce NavigableObject.wrap to coerce its arg to a NavigableObject. Maybe call this method "of"?
Deprecate MapWriter.EMPTY; don't need it anymore (due to the above); was only used once.
Enhance Utils to not need MapWriterMap for its functions, and to slightly optimize for SimpleOrderedMap becoming a Map soon.
Deprecate MapWriterMap. Ultimately may simply make package scope and maybe rename to orient itself around it's NavigableObject-ness, which is what it's only used for, after the changes here.
No JIRA: too internal; low impact.