[SPARK-50875][SQL] Add RTRIM collations to TVF #49554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @stefankandic and @dejankrak-db to take a look. |
stefankandic
approved these changes
Jan 17, 2025
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java
Show resolved
Hide resolved
cloud-fan
approved these changes
Jan 18, 2025
|
let's fix the python test failure |
MaxGekk
reviewed
Jan 20, 2025
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java
Outdated
Show resolved
Hide resolved
|
thanks, merging to master/4.0! |
cloud-fan
pushed a commit
that referenced
this pull request
Jan 21, 2025
### What changes were proposed in this pull request? Added all RTRIM collations to TVF when using `Collations` generator. ### Why are the changes needed? Since RTRIM collation is enabled by default, we need to add it to the list. ### Does this PR introduce _any_ user-facing change? Yes, using the `collations` function will include `rtrim` collations. ### How was this patch tested? Modified TVF collation tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49554 from stevomitric/stevomitric/add-rtrim-to-list. Authored-by: Stevo Mitric <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 5534b91) Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added all RTRIM collations to TVF when using
Collationsgenerator.Why are the changes needed?
Since RTRIM collation is enabled by default, we need to add it to the list.
Does this PR introduce any user-facing change?
Yes, using the
collationsfunction will includertrimcollations.How was this patch tested?
Modified TVF collation tests.
Was this patch authored or co-authored using generative AI tooling?
No.