Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-50864][TESTS] Disable slow tests #49664

Closed
wants to merge 3 commits into from
Closed

Conversation

ueshin
Copy link
Member

@ueshin ueshin commented Jan 25, 2025

What changes were proposed in this pull request?

Disables slow tests:

  • TorchDistributorDataLoaderUnitTests
  • TorchDistributorBaselineUnitTestsOnConnect

Why are the changes needed?

The tests above are slow or stuck, similar to other disabled tests for SPARK-50864.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Run on the GHA.

Was this patch authored or co-authored using generative AI tooling?

No.

@ueshin
Copy link
Member Author

ueshin commented Jan 25, 2025

ah, only an empty commit doesn't trigger pyspark tests. Let me try something else.

@ueshin
Copy link
Member Author

ueshin commented Feb 20, 2025

@zhengruifeng I guess my repo is hitting SPARK-50864?
When I disabled TorchDistributorDataLoaderUnitTests and TorchDistributorBaselineUnitTestsOnConnect, tests passed.

@ueshin ueshin changed the title [DO-NOT-MERGE] GHA Test. [TEST] Disables slow tests Feb 20, 2025
@ueshin ueshin changed the title [TEST] Disables slow tests [TESTS] Disables slow tests Feb 20, 2025
@ueshin ueshin changed the title [TESTS] Disables slow tests [TESTS] Disable slow tests Feb 20, 2025
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this change

@ueshin ueshin changed the title [TESTS] Disable slow tests [SPARK-50864][TESTS] Disable slow tests Feb 21, 2025
@ueshin
Copy link
Member Author

ueshin commented Feb 21, 2025

Thanks! merging to master.

@ueshin ueshin closed this in 1d72acc Feb 21, 2025
Pajaraja pushed a commit to Pajaraja/spark that referenced this pull request Mar 6, 2025
### What changes were proposed in this pull request?

Disables slow tests:

- `TorchDistributorDataLoaderUnitTests`
- `TorchDistributorBaselineUnitTestsOnConnect`

### Why are the changes needed?

The tests above are slow or stuck, similar to other disabled tests for [SPARK-50864](https://issues.apache.org/jira/browse/SPARK-50864).

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Run on the GHA.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#49664 from ueshin/gha_test.

Authored-by: Takuya UESHIN <[email protected]>
Signed-off-by: Takuya Ueshin <[email protected]>
kazemaksOG pushed a commit to kazemaksOG/spark-custom-scheduler that referenced this pull request Mar 27, 2025
### What changes were proposed in this pull request?

Disables slow tests:

- `TorchDistributorDataLoaderUnitTests`
- `TorchDistributorBaselineUnitTestsOnConnect`

### Why are the changes needed?

The tests above are slow or stuck, similar to other disabled tests for [SPARK-50864](https://issues.apache.org/jira/browse/SPARK-50864).

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Run on the GHA.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#49664 from ueshin/gha_test.

Authored-by: Takuya UESHIN <[email protected]>
Signed-off-by: Takuya Ueshin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants