Fix bug in histogram renderer

apache · Feb 6, 2024 · 279cf0e · 279cf0e
1 parent 81f7f10
commit 279cf0e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/ui/src/app/core-ui/echarts-transform/histogram.transform.ts b/ui/src/app/core-ui/echarts-transform/histogram.transform.ts
@@ -53,10 +53,10 @@ export const HistogramTransform: ExternalDataTransform<HistogramConfig> = {
         values.shift();
 
         let bins = bin();
-        if (!autoBin && numberOfBins) {
+        if (!autoBin && numberOfBins !== undefined) {
             bins = bins.thresholds(numberOfBins);
         }
-        if (!autoDomain && domainMin && domainMax) {
+        if (!autoDomain && domainMin !== undefined && domainMax !== undefined) {
             bins = bins.domain([domainMin, domainMax]);
         }
         const d3h = bins(values);

diff --git a/...explorer/components/widgets/histogram/config/histogram-chart-widget-config.component.html b/...explorer/components/widgets/histogram/config/histogram-chart-widget-config.component.html
@@ -37,7 +37,7 @@
                 [(ngModel)]="
                     currentlyConfiguredWidget.visualizationConfig.autoBin
                 "
-                (change)="triggerDataRefresh()"
+                (change)="triggerViewRefresh()"
             >
                 Auto-compute number of bins
             </mat-checkbox>