fix(#3372): Add test for pipeline users

apache · Dec 18, 2024 · 5ccba5f · 5ccba5f
1 parent 8bdb9d4
commit 5ccba5f
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 1 deletion.
diff --git a/ui/cypress/support/utils/pipeline/PipelineBtns.ts b/ui/cypress/support/utils/pipeline/PipelineBtns.ts
@@ -17,6 +17,14 @@
  */
 
 export class PipelineBtns {
+    public static statusPipeline() {
+        return cy.dataCy('status-pipeline-green', { timeout: 10000 });
+    }
+
+    public static stopPipeline() {
+        return cy.dataCy('stop-pipeline-button', { timeout: 10000 });
+    }
+
     public static deletePipeline() {
         return cy.dataCy('delete-pipeline', { timeout: 10000 });
     }

diff --git a/ui/cypress/support/utils/pipeline/PipelineUtils.ts b/ui/cypress/support/utils/pipeline/PipelineUtils.ts
@@ -169,7 +169,7 @@ export class PipelineUtils {
             cy.wait(1000);
             cy.dataCy('no-table-entries').should('be.visible');
         } else {
-            PipelineBtns.deletePipeline().should('have.length', amount);
+            PipelineBtns.statusPipeline().should('have.length', amount);
         }
     }
 

diff --git a/ui/cypress/tests/userManagement/testUserRolePipeline.spec.ts b/ui/cypress/tests/userManagement/testUserRolePipeline.spec.ts
@@ -22,6 +22,7 @@ import { ConnectUtils } from '../../support/utils/connect/ConnectUtils';
 import { PipelineUtils } from '../../support/utils/pipeline/PipelineUtils';
 import { GeneralUtils } from '../../support/utils/GeneralUtils';
 import { PermissionUtils } from '../../support/utils/user/PermissionUtils';
+import { PipelineBtns } from '../../support/utils/pipeline/PipelineBtns';
 
 describe('Test User Roles for Pipelines', () => {
     beforeEach('Setup Test', () => {
@@ -79,4 +80,26 @@ describe('Test User Roles for Pipelines', () => {
         PipelineUtils.goToPipelines();
         PipelineUtils.checkAmountOfPipelinesPipeline(1);
     });
+
+    it(' Pipeline user should see shared pipelines of other users but not be able to edit them', () => {
+        const newUser = UserUtils.createUser(
+            'user',
+            UserRole.ROLE_PIPELINE_USER,
+        );
+
+        // Add new authorized user to pipeline
+        PipelineUtils.goToPipelines();
+        // PermissionUtils.markElementAsPublic();
+        PermissionUtils.authorizeUser(newUser.email);
+
+        // Login as user and check if pipeline is visible to user
+        UserUtils.switchUser(newUser);
+
+        PipelineUtils.goToPipelines();
+        PipelineUtils.checkAmountOfPipelinesPipeline(1);
+
+        // A pipeline user should not be able to stop the pipeline or delete it
+        PipelineBtns.deletePipeline().should('not.exist');
+        PipelineBtns.stopPipeline().should('be.disabled');
+    });
 });
diff --git a/ui/src/app/pipelines/components/pipeline-overview/pipeline-overview.component.html b/ui/src/app/pipelines/components/pipeline-overview/pipeline-overview.component.html
@@ -28,6 +28,7 @@
             <div>
                 <div fxLayout="row" fxLayoutAlign="start center" fxFlex="150px">
                     <div
+                        data-cy="status-pipeline-green"
                         *ngIf="
                             pipeline.running && pipeline.healthStatus === 'OK'
                         "
@@ -116,6 +117,7 @@
                 mat-icon-button
                 matTooltip="Stop pipeline"
                 matTooltipPosition="above"
+                data-cy="stop-pipeline-button"
                 (click)="
                     pipelineOperationsService.stopPipeline(
                         pipeline._id,