Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve widget rendering in data explorer #2423

Merged
merged 20 commits into from
Feb 6, 2024
Merged
Show file tree
Hide file tree
Changes from 14 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ui/angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
],
"styles": ["src/scss/main.scss"],
"scripts": [
"node_modules/plotly.js/dist/plotly.min.js",
"node_modules/jquery/dist/jquery.min.js",
"node_modules/datatables.net/js/jquery.dataTables.js",
"node_modules/jquery-ui-dist/jquery-ui.js",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ describe('Test 2d Correlation View in Data Explorer', () => {
});

it('Perform Test', () => {
DataLakeUtils.addDataViewAndWidget('view', 'Persist', '2D Correlation');
DataLakeUtils.addDataViewAndWidget('view', 'Persist', 'Scatter');

// Check if scatter plot is displayed
cy.get('g').should('have.class', 'scatterlayer mlayer');
Expand Down
10 changes: 3 additions & 7 deletions ui/cypress/tests/datalake/widgets/distribution.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,26 +24,22 @@ describe('Test Distribution View in Data Explorer', () => {
});

it('Perform Test', () => {
DataLakeUtils.addDataViewAndWidget('view', 'Persist', 'Distribution');
DataLakeUtils.addDataViewAndWidget('view', 'Persist', 'Histogram');

// Change field for histogram
DataLakeUtils.selectVisualizationConfig();
cy.get('div').contains('randomtext (prepared_data #1)').click();
cy.get('div').contains('randomnumber (prepared_data #1)').click();

// Check if distribution chart is displayed
cy.get('sp-data-explorer-distribution-chart-widget').should(
'be.visible',
);
cy.dataCy('histogram-chart').should('be.visible');

// Change from histogram to heatmap
DataLakeUtils.selectVisualizationConfig();
cy.get('div').contains('Histogram').click();
cy.get('div').contains('Value Heatmap').click();

// Check if distribution chart is displayed
cy.get('sp-data-explorer-distribution-chart-widget').should(
'be.visible',
);
cy.dataCy('value-heatmap-chart').should('be.visible');
});
});
2 changes: 1 addition & 1 deletion ui/cypress/tests/datalake/widgets/heatmap.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,6 @@ describe('Test Heatmap View in Data Explorer', () => {
cy.get('mat-checkbox input').click({ force: true });

// Check if heatmap chart is visible
cy.get('sp-data-explorer-heatmap-widget').should('be.visible');
cy.dataCy('heatmap').should('be.visible');
});
});
Loading
Loading